WIP: fix tests with recent type changes

Author: jsayol

gulp/tasks/build.js

@@ -183,6 +183,11 @@ function compileIndvES2015ModulesToBrowser() {
         sourceMap: true
       })
     ],
+    node: {
+      fs: 'empty',
+      net: 'empty',
+      tls: 'empty'
+    },
     resolve: {
       extensions: ['.ts', '.tsx', '.js']
     },

gulp/tasks/test.integration.js

@@ -48,7 +48,13 @@ function compileTypescript() {
 function compileWebpack() {
   return gulp.src('tests-integration/bundlers/**/*.test.js')
     .pipe(named())
-    .pipe(webpackStream({}, webpack))
+    .pipe(webpackStream({
+      node: {
+        fs: 'empty',
+        net: 'empty',
+        tls: 'empty'
+      }
+    }, webpack))
     .pipe(rename(path => {
       const rawPath = path.basename.replace('.test', '');
       path.basename = `${rawPath}.webpack.test`;

tests/database/browser/crawler_support.test.ts

@@ -9,10 +9,10 @@ import {
 
 // Some sanity checks for the ReadonlyRestClient crawler support.
 describe('Crawler Support', function() {
-  var initialData;
-  var normalRef;
-  var restRef;
-  var tokenProvider;
+  let initialData;
+  let normalRef;
+  let restRef;
+  let tokenProvider;
 
   beforeEach(function(done) {
     normalRef = getRandomNode();

tests/database/compound_write.test.ts

@@ -7,7 +7,7 @@ import {
 import "../../src/database";
 
 describe('Database Tests', function() {
-  var defaultApp;
+  let defaultApp;
 
   beforeEach(function() {
     defaultApp = firebase.initializeApp({databaseURL: TEST_PROJECT.databaseURL});
@@ -19,74 +19,74 @@ describe('Database Tests', function() {
   });
 
   it('Can get database.', function() {
-    var db = firebase.database();
+    const db = firebase.database();
     expect(db).to.not.be.undefined;
     expect(db).not.to.be.null;
   });
 
   it('Illegal to call constructor', function() {
     expect(function() {
-      var db = new firebase.database.Database('url');
+      const db = new firebase.database.Database('url');
     }).to.throw(/don't call new Database/i);
   });
 
   it('Can get app', function() {
-    var db = firebase.database();
+    const db = firebase.database();
     expect(db.app).to.not.be.undefined;
     expect((db.app as any) instanceof firebase.app.App);
   });
 
   it('Can get root ref', function() {
-    var db = firebase.database();
+    const db = firebase.database();
 
-    var ref = db.ref();
+    const ref = db.ref();
 
     expect(ref instanceof firebase.database.Reference).to.be.true;
     expect(ref.key).to.be.null;
   });
 
   it('Can get child ref', function() {
-    var db = firebase.database();
+    const db = firebase.database();
 
-    var ref = db.ref('child');
+    const ref = db.ref('child');
 
     expect(ref instanceof firebase.database.Reference).to.be.true;
     expect(ref.key).to.equal('child');
   });
 
   it('Can get deep child ref', function() {
-    var db = firebase.database();
+    const db = firebase.database();
 
-    var ref = db.ref('child/grand-child');
+    const ref = db.ref('child/grand-child');
 
     expect(ref instanceof firebase.database.Reference).to.be.true;
     expect(ref.key).to.equal('grand-child');
   });
 
   it('ref() validates arguments', function() {
-    var db = firebase.database();
+    const db = firebase.database();
     expect(function() {
-      var ref = (db as any).ref('path', 'extra');
+      const ref = (db as any).ref('path', 'extra');
     }).to.throw(/Expects no more than 1/);
   });
 
   it('Can get refFromURL()', function() {
-    var db = firebase.database();
-    var ref = db.refFromURL(TEST_PROJECT.databaseURL + '/path/to/data');
+    const db = firebase.database();
+    const ref = db.refFromURL(TEST_PROJECT.databaseURL + '/path/to/data');
     expect(ref.key).to.equal('data');
   });
 
   it('refFromURL() validates domain', function() {
-    var db = firebase.database();
+    const db = firebase.database();
     expect(function() {
-      var ref = db.refFromURL('https://thisisnotarealfirebase.firebaseio.com/path/to/data');
+      const ref = db.refFromURL('https://thisisnotarealfirebase.firebaseio.com/path/to/data');
     }).to.throw(/does not match.*database/i);
   });
 
   it('refFromURL() validates argument', function() {
-    var db = firebase.database();
+    const db = firebase.database();
     expect(function() {
-      var ref = (db as any).refFromURL();
+      const ref = (db as any).refFromURL();
     }).to.throw(/Expects at least 1/);
   });
 });

tests/database/database.test.ts

@@ -7,13 +7,13 @@ import { Reference } from "../../src/database/api/Reference";
 
 describe("DataSnapshot Tests", function () {
   /** @return {!DataSnapshot} */
-  var snapshotForJSON = function(json) {
-    var dummyRef = <Reference>getRandomNode();
+  const snapshotForJSON = function(json) {
+    const dummyRef = <Reference>getRandomNode();
     return new DataSnapshot(nodeFromJSON(json), dummyRef, PRIORITY_INDEX);
   };
 
   it("DataSnapshot.hasChildren() works.", function() {
-    var snap = snapshotForJSON({});
+    let snap = snapshotForJSON({});
     expect(snap.hasChildren()).to.equal(false);
 
     snap = snapshotForJSON(5);
@@ -24,7 +24,7 @@ describe("DataSnapshot Tests", function () {
   });
 
   it("DataSnapshot.exists() works.", function() {
-    var snap = snapshotForJSON({});
+    let snap = snapshotForJSON({});
     expect(snap.exists()).to.equal(false);
 
     snap = snapshotForJSON({ '.priority':1 });
@@ -44,13 +44,13 @@ describe("DataSnapshot Tests", function () {
   });
 
   it("DataSnapshot.val() works.", function() {
-    var snap = snapshotForJSON(5);
+    let snap = snapshotForJSON(5);
     expect(snap.val()).to.equal(5);
 
     snap = snapshotForJSON({ });
     expect(snap.val()).to.equal(null);
 
-    var json =
+    const json =
     {
       x: 5,
       y: {
@@ -64,7 +64,7 @@ describe("DataSnapshot Tests", function () {
   });
 
   it("DataSnapshot.child() works.", function() {
-    var snap = snapshotForJSON({x: 5, y: { yy: 3, yz: 4}});
+    const snap = snapshotForJSON({x: 5, y: { yy: 3, yz: 4}});
     expect(snap.child('x').val()).to.equal(5);
     expect(snap.child('y').val()).to.deep.equal({yy: 3, yz: 4});
     expect(snap.child('y').child('yy').val()).to.equal(3);
@@ -75,7 +75,7 @@ describe("DataSnapshot Tests", function () {
   });
 
   it("DataSnapshot.hasChild() works.", function() {
-    var snap = snapshotForJSON({x: 5, y: { yy: 3, yz: 4}});
+    const snap = snapshotForJSON({x: 5, y: { yy: 3, yz: 4}});
     expect(snap.hasChild('x')).to.equal(true);
     expect(snap.hasChild('y/yy')).to.equal(true);
     expect(snap.hasChild('dinosaur')).to.equal(false);
@@ -84,7 +84,7 @@ describe("DataSnapshot Tests", function () {
   });
 
   it("DataSnapshot.key works.", function() {
-    var snap = snapshotForJSON({a: { b: { c: 5 }}});
+    const snap = snapshotForJSON({a: { b: { c: 5 }}});
     expect(snap.child('a').key).to.equal('a');
     expect(snap.child('a/b/c').key).to.equal('c');
     expect(snap.child('/a/b/c/').key).to.equal('c');
@@ -96,8 +96,8 @@ describe("DataSnapshot Tests", function () {
   });
 
   it("DataSnapshot.forEach() works: no priorities.", function() {
-    var snap = snapshotForJSON({a: 1, z: 26, m: 13, n: 14, c: 3, b: 2, e: 5});
-    var out = '';
+    const snap = snapshotForJSON({a: 1, z: 26, m: 13, n: 14, c: 3, b: 2, e: 5});
+    let out = '';
     snap.forEach(function(child) {
       out = out + child.key + ':' + child.val() + ':';
     });
@@ -106,7 +106,7 @@ describe("DataSnapshot Tests", function () {
   });
 
   it("DataSnapshot.forEach() works: numeric priorities.", function() {
-    var snap = snapshotForJSON({
+    const snap = snapshotForJSON({
       a: {'.value': 1, '.priority': 26},
       z: {'.value': 26, '.priority': 1},
       m: {'.value': 13, '.priority': 14},
@@ -115,7 +115,7 @@ describe("DataSnapshot Tests", function () {
       b: {'.value': 2, '.priority': 25},
       e: {'.value': 5, '.priority': 22}});
 
-    var out = '';
+    let out = '';
     snap.forEach(function(child) {
       out = out + child.key + ':' + child.val() + ':';
     });
@@ -124,7 +124,7 @@ describe("DataSnapshot Tests", function () {
   });
 
   it("DataSnapshot.forEach() works: numeric priorities as strings.", function() {
-    var snap = snapshotForJSON({
+    const snap = snapshotForJSON({
       a: {'.value': 1, '.priority': '26'},
       z: {'.value': 26, '.priority': '1'},
       m: {'.value': 13, '.priority': '14'},
@@ -133,7 +133,7 @@ describe("DataSnapshot Tests", function () {
       b: {'.value': 2, '.priority': '25'},
       e: {'.value': 5, '.priority': '22'}});
 
-    var out = '';
+    let out = '';
     snap.forEach(function(child) {
       out = out + child.key + ':' + child.val() + ':';
     });
@@ -142,7 +142,7 @@ describe("DataSnapshot Tests", function () {
   });
 
   it("DataSnapshot.forEach() works: alpha priorities.", function() {
-    var snap = snapshotForJSON({
+    const snap = snapshotForJSON({
       a: {'.value': 1, '.priority': 'first'},
       z: {'.value': 26, '.priority': 'second'},
       m: {'.value': 13, '.priority': 'third'},
@@ -151,7 +151,7 @@ describe("DataSnapshot Tests", function () {
       b: {'.value': 2, '.priority': 'sixth'},
       e: {'.value': 5, '.priority': 'seventh'}});
 
-    var out = '';
+    let out = '';
     snap.forEach(function(child) {
       out = out + child.key + ':' + child.val() + ':';
     });
@@ -160,7 +160,7 @@ describe("DataSnapshot Tests", function () {
   });
 
   it("DataSnapshot.foreach() works: mixed alpha and numeric priorities", function() {
-    var json = {
+    const json = {
       "alpha42": {'.value': 1, '.priority': "zed" },
       "noPriorityC": {'.value': 1, '.priority': null },
       "num41": {'.value': 1, '.priority': 500 },
@@ -181,8 +181,8 @@ describe("DataSnapshot Tests", function () {
       "alpha40": {'.value': 1, '.priority': "zed" },
       "num40": {'.value': 1, '.priority': 500 } };
 
-    var snap = snapshotForJSON(json);
-    var out = '';
+    const snap = snapshotForJSON(json);
+    let out = '';
     snap.forEach(function(child) {
       out = out + child.key + ', ';
     });
@@ -191,19 +191,19 @@ describe("DataSnapshot Tests", function () {
   });
 
   it(".val() exports array-like data as arrays.", function() {
-    var array = ['bob', 'and', 'becky', 'seem', 'really', 'nice', 'yeah?'];
-    var snap = snapshotForJSON(array);
-    var snapVal = snap.val();
+    const array = ['bob', 'and', 'becky', 'seem', 'really', 'nice', 'yeah?'];
+    const snap = snapshotForJSON(array);
+    const snapVal = snap.val();
     expect(snapVal).to.deep.equal(array);
     expect(snapVal instanceof Array).to.equal(true); // to.equal doesn't verify type.
   });
 
   it("DataSnapshot can be JSON serialized", function() {
-    var json = {
+    const json = {
       "foo": "bar",
       ".priority": 1
     };
-    var snap = snapshotForJSON(json);
+    const snap = snapshotForJSON(json);
     expect(JSON.parse(JSON.stringify(snap))).to.deep.equal(json);
   });
 });

tests/database/datasnapshot.test.ts

@@ -2,12 +2,12 @@ export const EventAccumulatorFactory = {
   waitsForCount: maxCount => {
     let count = 0;
     const condition = () => ea.eventData.length >= count;
-    const ea = new EventAccumulator(condition)
+    const ea = new EventAccumulator(condition);
     ea.onReset(() => { count = 0; });
     ea.onEvent(() => { count++; });
     return ea;
   }
-}
+};
 
 export class EventAccumulator {
   public eventData = [];