Skip to content

Commit 9304e47

Browse files
committed
Defer checking for Chrome
1 parent adef2fe commit 9304e47

File tree

4 files changed

+0
-29
lines changed

4 files changed

+0
-29
lines changed

common/api-review/util.api.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -264,11 +264,6 @@ export function isBrowser(): boolean;
264264
// @public (undocumented)
265265
export function isBrowserExtension(): boolean;
266266

267-
// Warning: (ae-missing-release-tag) "isChrome" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
268-
//
269-
// @public (undocumented)
270-
export function isChrome(): boolean;
271-
272267
// Warning: (ae-missing-release-tag) "isCloudflareWorker" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
273268
//
274269
// @public

packages/util/src/environment.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,6 @@ export function isSafari(): boolean {
173173
);
174174
}
175175

176-
export function isChrome(): boolean {
177-
return (
178-
!isNode() && !!navigator.userAgent && navigator.userAgent.includes('Chrome')
179-
);
180-
}
181-
182176
/**
183177
* This method checks if indexedDB is supported by current browser/service worker context
184178
* @return true if indexedDB is supported by current browser/service worker context

packages/vertexai/src/methods/chrome-adapter.test.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import {
2525
LanguageModelCreateOptions
2626
} from '../types/language-model';
2727
import { stub } from 'sinon';
28-
import * as util from '@firebase/util';
2928
import { GenerateContentRequest } from '../types';
3029

3130
use(sinonChai);
@@ -41,16 +40,6 @@ describe('ChromeAdapter', () => {
4140
})
4241
).to.be.false;
4342
});
44-
it('returns false if browser is not Chrome', async () => {
45-
const chromeStub = stub(util, 'isChrome').returns(false);
46-
const adapter = new ChromeAdapter(undefined, 'prefer_on_device');
47-
expect(
48-
await adapter.isAvailable({
49-
contents: []
50-
})
51-
).to.be.false;
52-
chromeStub.restore();
53-
});
5443
it('returns false if AI API is undefined', async () => {
5544
const adapter = new ChromeAdapter(undefined, 'prefer_on_device');
5645
expect(
@@ -175,7 +164,6 @@ describe('ChromeAdapter', () => {
175164
).to.be.false;
176165
});
177166
it('returns true if model is readily available', async () => {
178-
const chromeStub = stub(util, 'isChrome').returns(true);
179167
const languageModelProvider = {
180168
availability: () => Promise.resolve(Availability.available)
181169
} as LanguageModel;
@@ -188,7 +176,6 @@ describe('ChromeAdapter', () => {
188176
contents: [{ role: 'user', parts: [{ text: 'hi' }] }]
189177
})
190178
).to.be.true;
191-
chromeStub.restore();
192179
});
193180
it('returns false and triggers download when model is available after download', async () => {
194181
const languageModelProvider = {

packages/vertexai/src/methods/chrome-adapter.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import {
3030
LanguageModelMessageRole,
3131
LanguageModelMessageContent
3232
} from '../types/language-model';
33-
import { isChrome } from '@firebase/util';
3433

3534
/**
3635
* Defines an inference "backend" that uses Chrome's on-device model,
@@ -66,10 +65,6 @@ export class ChromeAdapter {
6665
if (this.mode === 'only_in_cloud') {
6766
return false;
6867
}
69-
// Returns false because only Chrome's experimental Prompt API is supported.
70-
if (!isChrome()) {
71-
return false;
72-
}
7368
// Returns false if the on-device inference API is undefined.;
7469
if (!this.languageModelProvider) {
7570
return false;

0 commit comments

Comments
 (0)