WIP: fix data spec tests

Author: jshcrowthe

src/database.ts

@@ -21,6 +21,7 @@ import { Query } from "./database/api/Query";
 import { Reference } from "./database/api/Reference";
 import { enableLogging } from "./database/core/util/util";
 import { RepoManager } from "./database/core/RepoManager";
+import * as INTERNAL from './database/api/internal';
 
 export function registerDatabase(instance) {
   // Register the Database Service with the 'firebase' namespace.
@@ -33,6 +34,7 @@ export function registerDatabase(instance) {
       Query,
       Database,
       enableLogging,
+      INTERNAL,
       ServerValue: Database.ServerValue,
     }
   );

src/database/core/snap/nodeFromJSON.ts

@@ -22,12 +22,11 @@ export function nodeFromJSON(json, priority?) {
     return ChildrenNode.EMPTY_NODE;
   }
 
-  var priority = null;
+  priority = priority || null;
   if (typeof json === 'object' && '.priority' in json) {
     priority = json['.priority'];
-  } else if (typeof priority !== 'undefined') {
-    priority = priority;
   }
+  
   assert(
       priority === null ||
       typeof priority === 'string' ||
@@ -79,7 +78,7 @@ export function nodeFromJSON(json, priority?) {
   } else {
     var node = ChildrenNode.EMPTY_NODE;
     var jsonObj = /** @type {!Object} */ (json);
-    forEach(jsonObj, function(childData, key) {
+    forEach(jsonObj, function(key, childData) {
       if (contains(jsonObj, key)) {
         if (key.substring(0, 1) !== '.') { // ignore metadata nodes.
           var childNode = nodeFromJSON(childData);

src/utils/Sha1.ts

@@ -185,7 +185,7 @@ export class Sha1 extends Hash {
       return;
     }
 
-    if (opt_length === 'undefined') {
+    if (opt_length === undefined) {
       opt_length = bytes.length;
     }