Skip to content

Commit 34c658e

Browse files
committed
Remove redundant ondevice suffix
1 parent 025b786 commit 34c658e

File tree

4 files changed

+10
-12
lines changed

4 files changed

+10
-12
lines changed

packages/vertexai/src/methods/chrome-adapter.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ describe('ChromeAdapter', () => {
299299
const request = {
300300
contents: [{ role: 'user', parts: [{ text: 'anything' }] }]
301301
} as GenerateContentRequest;
302-
const response = await adapter.generateContentOnDevice(request);
302+
const response = await adapter.generateContent(request);
303303
// Asserts initialization params are proxied.
304304
expect(createStub).to.have.been.calledOnceWith(onDeviceParams);
305305
// Asserts Vertex input type is mapped to Chrome type.
@@ -355,7 +355,7 @@ describe('ChromeAdapter', () => {
355355
const request = {
356356
contents: [{ role: 'user', parts: [{ text: 'anything' }] }]
357357
} as GenerateContentRequest;
358-
const response = await adapter.generateContentStreamOnDevice(request);
358+
const response = await adapter.generateContentStream(request);
359359
expect(createStub).to.have.been.calledOnceWith(onDeviceParams);
360360
expect(promptStub).to.have.been.calledOnceWith([
361361
{

packages/vertexai/src/methods/chrome-adapter.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,7 @@ export class ChromeAdapter {
9494
* @param request a standard Vertex {@link GenerateContentRequest}
9595
* @returns {@link Response}, so we can reuse common response formatting.
9696
*/
97-
async generateContentOnDevice(
98-
request: GenerateContentRequest
99-
): Promise<Response> {
97+
async generateContent(request: GenerateContentRequest): Promise<Response> {
10098
const session = await this.createSession(
10199
// TODO: normalize on-device params during construction.
102100
this.onDeviceParams || {}
@@ -105,7 +103,7 @@ export class ChromeAdapter {
105103
const text = await session.prompt(messages);
106104
return ChromeAdapter.toResponse(text);
107105
}
108-
async generateContentStreamOnDevice(
106+
async generateContentStream(
109107
request: GenerateContentRequest
110108
): Promise<Response> {
111109
const session = await this.createSession(

packages/vertexai/src/methods/generate-content.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -308,17 +308,17 @@ describe('generateContent()', () => {
308308
);
309309
expect(mockFetch).to.be.called;
310310
});
311+
// TODO: define a similar test for generateContentStream
311312
it('on-device', async () => {
312313
const chromeAdapter = new ChromeAdapter();
313314
const isAvailableStub = stub(chromeAdapter, 'isAvailable').resolves(true);
314315
const mockResponse = getMockResponse(
315316
'vertexAI',
316317
'unary-success-basic-reply-short.json'
317318
);
318-
const generateContentStub = stub(
319-
chromeAdapter,
320-
'generateContentOnDevice'
321-
).resolves(mockResponse as Response);
319+
const generateContentStub = stub(chromeAdapter, 'generateContent').resolves(
320+
mockResponse as Response
321+
);
322322
const result = await generateContent(
323323
fakeApiSettings,
324324
'model',

packages/vertexai/src/methods/generate-content.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export async function generateContentStream(
5353
): Promise<GenerateContentStreamResult> {
5454
let response;
5555
if (await chromeAdapter.isAvailable(params)) {
56-
response = await chromeAdapter.generateContentStreamOnDevice(params);
56+
response = await chromeAdapter.generateContentStream(params);
5757
} else {
5858
response = await generateContentStreamOnCloud(
5959
apiSettings,
@@ -90,7 +90,7 @@ export async function generateContent(
9090
): Promise<GenerateContentResult> {
9191
let response;
9292
if (await chromeAdapter.isAvailable(params)) {
93-
response = await chromeAdapter.generateContentOnDevice(params);
93+
response = await chromeAdapter.generateContent(params);
9494
} else {
9595
response = await generateContentOnCloud(
9696
apiSettings,

0 commit comments

Comments
 (0)