Skip to content

Commit 1494c4b

Browse files
authored
Enable previously failing (Firestore) Node.js and Browser (Chrome) Tests (#8067)
A Firestore CI test configuration was previously disabled in our GitHub action Workflows due to a 100% failure rate. While revisiting this issue months later, it seems that the test now passes. This might be related to our Node v20 CI upgrade. As a bonus, fixed a comment typo in the check changeset script.
1 parent 1eb302f commit 1494c4b

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

.github/workflows/test-all.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,6 @@ jobs:
161161
name: (Firestore) Node.js and Browser (Chrome) Tests
162162
needs: build
163163
runs-on: ubuntu-latest
164-
if: false
165-
# Disable test for now since it's failing 100% of the time since
166-
# https://github.com/firebase/firebase-js-sdk/pull/7453 and it needs to be investigated.
167164
steps:
168165
# install Chrome so the correct version of webdriver can be installed by chromedriver when setting up the repo
169166
- name: install Chrome stable

scripts/ci/check_changeset.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const bumpRank: Record<string, number> = {
4646

4747
/**
4848
* Get highest bump that isn't the main firebase package, return
49-
// numerical rank, bump text, package name.
49+
* numerical rank, bump text, package name.
5050
*/
5151
function getHighestBump(changesetPackages: Record<string, string>) {
5252
const firebasePkgJson = require(resolve(

0 commit comments

Comments
 (0)