Merge branch 'master' into launch.next

Author: taeold

spec/runtime/manifest.spec.ts

@@ -7,6 +7,36 @@ describe("stackToWire", () => {
     params.clearParams();
   });
 
+  it("converts stack with null values values", () => {
+    const stack: ManifestStack = {
+      endpoints: {
+        v2http: {
+          platform: "gcfv2",
+          entryPoint: "v2http",
+          labels: {},
+          httpsTrigger: {},
+          maxInstances: null,
+        },
+      },
+      requiredAPIs: [],
+      specVersion: "v1alpha1",
+    };
+    const expected = {
+      endpoints: {
+        v2http: {
+          platform: "gcfv2",
+          entryPoint: "v2http",
+          labels: {},
+          httpsTrigger: {},
+          maxInstances: null,
+        },
+      },
+      requiredAPIs: [],
+      specVersion: "v1alpha1",
+    };
+    expect(stackToWire(stack)).to.deep.equal(expected);
+  });
+
   it("converts Expression types in endpoint options to CEL", () => {
     const intParam = params.defineInt("foo", { default: 11 });
     const stringParam = params.defineString("bar", {

src/runtime/manifest.ts

@@ -107,7 +107,7 @@ export function stackToWire(stack: ManifestStack): Record<string, unknown> {
     for (const [key, val] of Object.entries(obj)) {
       if (val instanceof Expression) {
         obj[key] = val.toCEL();
-      } else if (typeof val === "object") {
+      } else if (typeof val === "object" && val !== null) {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
         traverse(val as any);
       }

src/v2/providers/alerts/appDistribution.ts

@@ -50,6 +50,8 @@ export interface NewTesterDevicePayload {
 /**
  * The internal payload object for receiving in-app feedback from a tester.
  * Payload is wrapped inside a `FirebaseAlertData` object.
+ *
+ * @alpha
  */
 export interface InAppFeedbackPayload {
   ["@type"]: "type.googleapis.com/google.events.firebase.firebasealerts.v1.AppDistroInAppFeedbackPayload";
@@ -258,6 +260,8 @@ export function onNewTesterIosDevicePublished(
  * Declares a function that can handle receiving new in-app feedback from a tester.
  * @param handler - Event handler which is run every time new feedback is received.
  * @returns A function that you can export and deploy.
+ *
+ * @alpha
  */
 export function onInAppFeedbackPublished(
   handler: (event: AppDistributionEvent<InAppFeedbackPayload>) => any | Promise<any>
@@ -268,6 +272,8 @@ export function onInAppFeedbackPublished(
  * @param appId - A specific application the handler will trigger on.
  * @param handler - Event handler which is run every time new feedback is received.
  * @returns A function that you can export and deploy.
+ *
+ * @alpha
  */
 export function onInAppFeedbackPublished(
   appId: string,
@@ -279,6 +285,8 @@ export function onInAppFeedbackPublished(
  * @param opts - Options that can be set on the function.
  * @param handler - Event handler which is run every time new feedback is received.
  * @returns A function that you can export and deploy.
+ *
+ * @alpha
  */
 export function onInAppFeedbackPublished(
   opts: AppDistributionOptions,
@@ -290,6 +298,8 @@ export function onInAppFeedbackPublished(
  * @param appIdOrOptsOrHandler - A specific application, options, or an event-handling function.
  * @param handler - Event handler which is run every time new feedback is received.
  * @returns A function that you can export and deploy.
+ *
+ * @alpha
  */
 export function onInAppFeedbackPublished(
   appIdOrOptsOrHandler: