Fix low hanging eslint issues.

Author: taeold

.eslintrc.js

@@ -51,7 +51,6 @@ module.exports = {
         "@typescript-eslint/no-unsafe-member-access": "warn",
         "@typescript-eslint/no-unsafe-return": "warn",
         "@typescript-eslint/restrict-template-expressions": "warn",
-        "no-constant-condition": "warn",
       },
     },
     {

integration_test/functions/src/index.ts

@@ -159,7 +159,7 @@ export const integrationTests: any = functions
     await admin.database().ref(`testRuns/${testId}/timestamp`).set(Date.now());
     const testIdRef = admin.database().ref(`testRuns/${testId}`);
     functions.logger.info("testId is: ", testId);
-    fs.writeFile("/tmp/" + testId + ".txt", "test", () => undefined);
+    fs.writeFile(`/tmp/${testId}.txt`, "test", () => undefined);
     try {
       const accessToken = await admin.credential.applicationDefault().getAccessToken();
       await Promise.all([

scripts/bin-test/test.ts

@@ -65,7 +65,7 @@ async function retryUntil(
     }, timeoutMs);
   });
   const retry = (async () => {
-    while (true) {
+    for (;;) {
       if (await fn()) {
         break;
       }

src/common/providers/tasks.ts

@@ -143,12 +143,12 @@ export function onDispatchHandler<Req = any>(
         };
         // For some reason the type system isn't picking up that the handler
         // is a one argument function.
-        await (handler as any)(arg);
+        await (handler as v2TaskHandler<Req>)(arg);
       }
 
       res.status(204).end();
     } catch (err) {
-      let httpErr = err;
+      let httpErr: https.HttpsError = err;
       if (!(err instanceof https.HttpsError)) {
         // This doesn't count as an 'explicit' error.
         logger.error("Unhandled error", err);