From 16f363265724b87bf78df7555785572178326796 Mon Sep 17 00:00:00 2001 From: Daniel Young Lee Date: Fri, 28 Apr 2023 16:30:26 -0700 Subject: [PATCH 1/3] fix: Wire up firestore reference in emaulted environment. --- src/firebase_functions/firestore_fn.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/firebase_functions/firestore_fn.py b/src/firebase_functions/firestore_fn.py index b8636d2..54d309e 100644 --- a/src/firebase_functions/firestore_fn.py +++ b/src/firebase_functions/firestore_fn.py @@ -26,6 +26,7 @@ import firebase_functions.core as _core import cloudevents.http as _ce +from firebase_admin import get_app, _apps, _DEFAULT_APP_NAME from google.cloud._helpers import _datetime_to_pb_timestamp from google.cloud.firestore_v1 import _helpers as _firestore_helpers @@ -115,7 +116,10 @@ def _firestore_endpoint_handler( "%Y-%m-%dT%H:%M:%S.%f%z", ) - firestore_client = _firestore_v1.Client(database=event_database) + if _DEFAULT_APP_NAME not in _apps: + initialize_app() + app = get_app() + firestore_client = _firestore_v1.Client(project=app.project_id, database=event_database) firestore_ref: DocumentReference = firestore_client.document(event_document) value_snapshot: DocumentSnapshot | None = None old_value_snapshot: DocumentSnapshot | None = None From cde95f12e5e897414f7a49aafbbd9483b8672b49 Mon Sep 17 00:00:00 2001 From: Daniel Young Lee Date: Fri, 28 Apr 2023 16:36:55 -0700 Subject: [PATCH 2/3] Add forgotten import. --- src/firebase_functions/firestore_fn.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/firebase_functions/firestore_fn.py b/src/firebase_functions/firestore_fn.py index 54d309e..de280f9 100644 --- a/src/firebase_functions/firestore_fn.py +++ b/src/firebase_functions/firestore_fn.py @@ -26,7 +26,7 @@ import firebase_functions.core as _core import cloudevents.http as _ce -from firebase_admin import get_app, _apps, _DEFAULT_APP_NAME +from firebase_admin import initialize_app, get_app, _apps, _DEFAULT_APP_NAME from google.cloud._helpers import _datetime_to_pb_timestamp from google.cloud.firestore_v1 import _helpers as _firestore_helpers From 01a023c670f98cfabc711d843b762b279b0d039a Mon Sep 17 00:00:00 2001 From: Daniel Young Lee Date: Fri, 28 Apr 2023 16:39:15 -0700 Subject: [PATCH 3/3] Fix formatting. --- src/firebase_functions/firestore_fn.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/firebase_functions/firestore_fn.py b/src/firebase_functions/firestore_fn.py index de280f9..b8ae498 100644 --- a/src/firebase_functions/firestore_fn.py +++ b/src/firebase_functions/firestore_fn.py @@ -119,7 +119,8 @@ def _firestore_endpoint_handler( if _DEFAULT_APP_NAME not in _apps: initialize_app() app = get_app() - firestore_client = _firestore_v1.Client(project=app.project_id, database=event_database) + firestore_client = _firestore_v1.Client(project=app.project_id, + database=event_database) firestore_ref: DocumentReference = firestore_client.document(event_document) value_snapshot: DocumentSnapshot | None = None old_value_snapshot: DocumentSnapshot | None = None