Skip to content

Commit 1f9c98a

Browse files
committed
Temporarily remove ump_resources to see if this fixes Windows build hang.
1 parent d6fc10b commit 1f9c98a

File tree

5 files changed

+29
-18
lines changed

5 files changed

+29
-18
lines changed

gma/CMakeLists.txt

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,19 @@ binary_to_array("gma_resources"
3838
"${FIREBASE_GEN_FILE_DIR}/gma")
3939

4040
# Define the resource build needed for Android
41-
firebase_cpp_gradle(":gma:ump_resources:generateDexJarRelease"
42-
"${CMAKE_CURRENT_LIST_DIR}/ump_resources/build/ump_resources_lib.jar")
43-
binary_to_array("ump_resources"
44-
"${CMAKE_CURRENT_LIST_DIR}/ump_resources/build/ump_resources_lib.jar"
45-
"firebase_ump"
46-
"${FIREBASE_GEN_FILE_DIR}/gma")
41+
# TODO(jsimantov): Temporarily remove to diagnose Windows build issue.
42+
#firebase_cpp_gradle(":gma:ump_resources:generateDexJarRelease"
43+
# "${CMAKE_CURRENT_LIST_DIR}/ump_resources/build/ump_resources_lib.jar")
44+
#binary_to_array("ump_resources"
45+
# "${CMAKE_CURRENT_LIST_DIR}/ump_resources/build/ump_resources_lib.jar"
46+
# "firebase_ump"
47+
# "${FIREBASE_GEN_FILE_DIR}/gma")
4748

4849
# Source files used by the Android implementation.
50+
# TODO(jsimantov): Temporarily remove to diagnose Windows build issue.
51+
# ${ump_resources_source}
4952
set(android_SRCS
5053
${gma_resources_source}
51-
${ump_resources_source}
5254
src/android/ump/consent_info_internal_android.cc
5355
src/android/ad_request_converter.cc
5456
src/android/ad_error_android.cc

gma/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,5 +85,6 @@ apply from: "$rootDir/android_build_files/generate_proguard.gradle"
8585
project.afterEvaluate {
8686
generateProguardFile('gma')
8787
setupDexDependencies(':gma:gma_resources')
88-
setupDexDependencies(':gma:ump_resources')
88+
// TODO(jsimantov): Temporarily remove to diagnose Windows build issue.
89+
// setupDexDependencies(':gma:ump_resources')
8990
}

gma/integration_test/build.gradle

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ android {
7373
proguardFile file('proguard.pro')
7474
}
7575
}
76+
lintOptions {
77+
abortOnError false
78+
}
7679
}
7780

7881
apply from: "$gradle.firebase_cpp_sdk_dir/Android/firebase_dependencies.gradle"

gma/src/android/ump/consent_info_internal_android.cc

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
#include "app/src/thread.h"
2626
#include "app/src/util_android.h"
2727
#include "firebase/internal/common.h"
28-
#include "gma/ump_resources.h"
28+
// TODO(jsimantov): Temporarily remove to diagnose Windows build issue.
29+
// #include "gma/ump_resources.h"
2930

3031
namespace firebase {
3132
namespace gma {
@@ -261,14 +262,17 @@ ConsentInfoInternalAndroid::ConsentInfoInternalAndroid(JNIEnv* env,
261262
util::Initialize(env, activity);
262263
env->GetJavaVM(&java_vm_);
263264

264-
const std::vector<firebase::internal::EmbeddedFile> embedded_files =
265-
util::CacheEmbeddedFiles(env, activity,
266-
firebase::internal::EmbeddedFile::ToVector(
267-
firebase_ump::ump_resources_filename,
268-
firebase_ump::ump_resources_data,
269-
firebase_ump::ump_resources_size));
270-
if (!(consent_info_helper::CacheClassFromFiles(env, activity,
271-
&embedded_files) != nullptr &&
265+
// TODO(jsimantov): Temporarily remove to diagnose Windows build issue.
266+
// const std::vector<firebase::internal::EmbeddedFile> embedded_files =
267+
// util::CacheEmbeddedFiles(env, activity,
268+
// firebase::internal::EmbeddedFile::ToVector(
269+
// firebase_ump::ump_resources_filename,
270+
// firebase_ump::ump_resources_data,
271+
// firebase_ump::ump_resources_size));
272+
if (
273+
// TODO(jsimantov): Temporarily remove to diagnose Windows build issue.
274+
// !(consent_info_helper::CacheClassFromFiles(env, activity,
275+
// &embedded_files) != nullptr &&
272276
consent_info_helper::CacheMethodIds(env, activity) &&
273277
consent_info_helper::CacheFieldIds(env, activity) &&
274278
consentinformation_consentstatus::CacheFieldIds(env, activity) &&

settings.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
rootProject.name = 'firebase_cpp_sdk'
2+
// TODO(jsimantov): Temporarily remove to diagnose Windows build issue.
3+
// ':gma:ump_resources',
24
include ':app',
35
':app:app_resources',
46
':app:google_api_resources',
@@ -16,7 +18,6 @@ include ':app',
1618
':functions',
1719
':gma',
1820
':gma:gma_resources',
19-
':gma:ump_resources',
2021
':installations',
2122
':messaging',
2223
':messaging:messaging_java',

0 commit comments

Comments
 (0)