Skip to content

Commit ffebd3c

Browse files
authored
Defined linter as a separate job (#398)
* Defined linter as a separate job * Added missing env config * Fixed pylint install directive * Installing all dependencies * Disabling fail fast for build matrix * Merged with master
1 parent 04e2b1b commit ffebd3c

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

.github/workflows/ci.yml

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ on: [push, pull_request]
44

55
jobs:
66
build:
7-
87
runs-on: ubuntu-latest
98
strategy:
9+
fail-fast: false
1010
matrix:
1111
python: [3.5, 3.6, 3.7, pypy3]
1212

@@ -20,11 +20,7 @@ jobs:
2020
run: |
2121
python -m pip install --upgrade pip
2222
pip install -r requirements.txt
23-
- name: Lint with pylint
24-
if: matrix.python == '3.7'
25-
run: ./lint.sh all
2623
- name: Test with pytest
27-
if: success() || failure()
2824
run: pytest
2925
- name: Set up Node.js 10
3026
uses: actions/setup-node@v1
@@ -34,3 +30,18 @@ jobs:
3430
run: |
3531
npm install -g firebase-tools
3632
firebase emulators:exec --only database --project fake-project-id 'pytest integration/test_db.py'
33+
34+
lint:
35+
runs-on: ubuntu-latest
36+
steps:
37+
- uses: actions/checkout@v1
38+
- name: Set up Python 3.7
39+
uses: actions/setup-python@v1
40+
with:
41+
python-version: 3.7
42+
- name: Install dependencies
43+
run: |
44+
python -m pip install --upgrade pip
45+
pip install -r requirements.txt
46+
- name: Lint with pylint
47+
run: ./lint.sh all

0 commit comments

Comments
 (0)