diff --git a/src/main/java/com/google/firebase/auth/FirebaseUserManager.java b/src/main/java/com/google/firebase/auth/FirebaseUserManager.java index c7e832510..17186ea89 100644 --- a/src/main/java/com/google/firebase/auth/FirebaseUserManager.java +++ b/src/main/java/com/google/firebase/auth/FirebaseUserManager.java @@ -254,9 +254,6 @@ Tenant createTenant(Tenant.CreateRequest request) throws FirebaseAuthException { Tenant updateTenant(Tenant.UpdateRequest request) throws FirebaseAuthException { Map properties = request.getProperties(); - // TODO(micahstairs): Move this check so that argument validation happens outside the - // CallableOperation. - checkArgument(!properties.isEmpty(), "tenant update must have at least one property set"); GenericUrl url = new GenericUrl(tenantMgtBaseUrl + getTenantUrlSuffix(request.getTenantId())); url.put("updateMask", Joiner.on(",").join(generateMask(properties))); return sendRequest("PATCH", url, properties, Tenant.class); diff --git a/src/main/java/com/google/firebase/auth/TenantManager.java b/src/main/java/com/google/firebase/auth/TenantManager.java index 0b6175534..4b3bbb948 100644 --- a/src/main/java/com/google/firebase/auth/TenantManager.java +++ b/src/main/java/com/google/firebase/auth/TenantManager.java @@ -68,7 +68,7 @@ public Tenant getTenant(@NonNull String tenantId) throws FirebaseAuthException { } public synchronized TenantAwareFirebaseAuth getAuthForTenant(@NonNull String tenantId) { - checkArgument(!Strings.isNullOrEmpty(tenantId), "tenantId must not be null or empty"); + checkArgument(!Strings.isNullOrEmpty(tenantId), "Tenant ID must not be null or empty."); if (!tenantAwareAuths.containsKey(tenantId)) { tenantAwareAuths.put(tenantId, new TenantAwareFirebaseAuth(firebaseApp, tenantId)); } @@ -90,7 +90,7 @@ public ApiFuture getTenantAsync(@NonNull String tenantId) { private CallableOperation getTenantOp(final String tenantId) { checkNotDestroyed(); - checkArgument(!Strings.isNullOrEmpty(tenantId), "tenantId must not be null or empty"); + checkArgument(!Strings.isNullOrEmpty(tenantId), "Tenant ID must not be null or empty."); return new CallableOperation() { @Override protected Tenant execute() throws FirebaseAuthException { @@ -196,7 +196,7 @@ public ApiFuture createTenantAsync(@NonNull CreateRequest request) { private CallableOperation createTenantOp( final CreateRequest request) { checkNotDestroyed(); - checkNotNull(request, "create request must not be null"); + checkNotNull(request, "Create request must not be null."); return new CallableOperation() { @Override protected Tenant execute() throws FirebaseAuthException { @@ -234,7 +234,9 @@ public ApiFuture updateTenantAsync(@NonNull UpdateRequest request) { private CallableOperation updateTenantOp( final UpdateRequest request) { checkNotDestroyed(); - checkNotNull(request, "update request must not be null"); + checkNotNull(request, "Update request must not be null."); + checkArgument(!request.getProperties().isEmpty(), + "Tenant update must have at least one property set."); return new CallableOperation() { @Override protected Tenant execute() throws FirebaseAuthException { @@ -269,7 +271,7 @@ public ApiFuture deleteTenantAsync(String tenantId) { private CallableOperation deleteTenantOp(final String tenantId) { checkNotDestroyed(); - checkArgument(!Strings.isNullOrEmpty(tenantId), "tenantId must not be null or empty"); + checkArgument(!Strings.isNullOrEmpty(tenantId), "Tenant ID must not be null or empty."); return new CallableOperation() { @Override protected Void execute() throws FirebaseAuthException {