Skip to content

Commit 810eb4b

Browse files
committed
Address two suggestions.
1 parent 06d1db9 commit 810eb4b

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/main/java/com/google/firebase/auth/AbstractFirebaseAuth.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -939,7 +939,7 @@ protected String execute() throws FirebaseAuthException {
939939
}
940940

941941
/**
942-
* Creates a new provider OIDC Auth provider config with the attributes contained in the specified
942+
* Creates a new OIDC Auth provider config with the attributes contained in the specified
943943
* {@link OidcProviderConfig.CreateRequest}.
944944
*
945945
* @param request A non-null {@link OidcProviderConfig.CreateRequest} instance.
@@ -1196,7 +1196,7 @@ protected Void execute() throws FirebaseAuthException {
11961196
}
11971197

11981198
/**
1199-
* Creates a new provider SAML Auth provider config with the attributes contained in the specified
1199+
* Creates a new SAML Auth provider config with the attributes contained in the specified
12001200
* {@link SamlProviderConfig.CreateRequest}.
12011201
*
12021202
* @param request A non-null {@link SamlProviderConfig.CreateRequest} instance.

src/test/java/com/google/firebase/auth/OidcProviderConfigTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,23 +52,23 @@ public void testJsonDeserialization() throws IOException {
5252
}
5353

5454
@Test
55-
public void testCheckSamlProviderId() {
56-
SamlProviderConfig.checkSamlProviderId("saml.valid-id");
55+
public void testCheckOidcProviderId() {
56+
OidcProviderConfig.checkOidcProviderId("oidc.valid-id");
5757
}
5858

5959
@Test(expected = IllegalArgumentException.class)
60-
public void testCreateSamlProviderIdNull() {
61-
SamlProviderConfig.checkSamlProviderId(null);
60+
public void testCreateOidcProviderIdNull() {
61+
OidcProviderConfig.checkOidcProviderId(null);
6262
}
6363

6464
@Test(expected = IllegalArgumentException.class)
65-
public void testCreateSamlProviderIdEmpty() {
66-
SamlProviderConfig.checkSamlProviderId("");
65+
public void testCreateOidcProviderIdEmpty() {
66+
OidcProviderConfig.checkOidcProviderId("");
6767
}
6868

6969
@Test(expected = IllegalArgumentException.class)
70-
public void testCreateSamlProviderIdInvalidPrefix() {
71-
SamlProviderConfig.checkSamlProviderId("not prefixed with saml.");
70+
public void testCreateOidcProviderIdInvalidPrefix() {
71+
OidcProviderConfig.checkOidcProviderId("not prefixed with oidc.");
7272
}
7373

7474
@Test

0 commit comments

Comments
 (0)