Skip to content

Commit 1360d69

Browse files
gkioxarifacebook-github-bot
authored andcommitted
minor note fix
Summary: A small fix for the iou3d note Reviewed By: bottler Differential Revision: D31370686 fbshipit-source-id: 6c97302b5c78de52915f31be70f234179c4b246d
1 parent 4281df1 commit 1360d69

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

docs/notes/iou3d.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ In 2D, IoU is commonly applied to axis-aligned boxes, namely boxes with edges pa
1616
In 3D, boxes are usually not axis aligned and can be oriented in any way in the world.
1717
We introduce a new algorithm which computes the *exact* IoU of two *oriented 3D boxes*.
1818

19-
Our algorithm is based on the simple observation that the intersection of two oriented boxes, `box1` and `box2`, is a convex n-gon with `n > 2` comprised of connected *planar units*.
19+
Our algorithm is based on the simple observation that the intersection of two oriented 3D boxes, `box1` and `box2`, is a convex polyhedron (convex n-gon in 2D) with `n > 2` comprised of connected *planar units*.
2020
In 3D, these planar units are 3D triangular faces.
2121
In 2D, they are 2D edges.
2222
Each planar unit belongs strictly to either `box1` or `box2`.
@@ -46,12 +46,12 @@ The intersection shape is formed by the convex hull from the intersection points
4646

4747
Our algorithm has several advantages over Objectron's:
4848

49-
1. Our algorithm also computes the points of intersection, similar to Objectron, but in addition stores the *planar units* the points belong to. This eliminates the need for convex hull computation which is `O(nlogn)` and relies on a third party library which often crashes with nondescript error messages.
50-
2. Objectron's implementation assumes that boxes are a rotation away from axis aligned. Our algorithm and implementation makes no such assumption and works for any 3D boxes.
51-
3. Our implementation supports batching, unlike Objectron which assumes single element inputs for `box1` and `box2`.
52-
4. Our implementation is easily parallelizable and in fact we provide a custom C++/CUDA implementation which is **450 times faster than Objectron**.
49+
* Our algorithm also computes the points of intersection, similar to Objectron, but in addition stores the *planar units* the points belong to. This eliminates the need for convex hull computation which is `O(nlogn)` and relies on a third party library which often crashes with nondescript error messages.
50+
* Objectron's implementation assumes that boxes are a rotation away from axis aligned. Our algorithm and implementation make no such assumption and work for any 3D boxes.
51+
* Our implementation supports batching, unlike Objectron which assumes single element inputs for `box1` and `box2`.
52+
* Our implementation is easily parallelizable and in fact we provide a custom C++/CUDA implementation which is **450 times faster than Objectron**.
5353

54-
Below we compare the performance for Objectron (in C++) and our algorithm, in C++ and CUDA. We benchmark for a common use case in object detection where `boxes1` hold M predictions and `boxes2` hold N ground truth 3D boxes in an image. We compute the `MxN` IoU matrix and report the time in ms for `M=N=16`.
54+
Below we compare the performance for Objectron (in C++) and our algorithm, in C++ and CUDA. We benchmark for a common use case in object detection where `boxes1` hold M predictions and `boxes2` hold N ground truth 3D boxes in an image and compute the `MxN` IoU matrix. We report the time in ms for `M=N=16`.
5555

5656
<p align="center">
5757
<img src="assets/iou3d_comp.png" alt="drawing" width="400"/>

0 commit comments

Comments
 (0)