Skip to content

Commit bf3656b

Browse files
vincentriemerfacebook-github-bot
authored andcommitted
- Ensure move tracking is applied to pressed moves
Summary: Changelog: [Internal] - Ensure pointer move tracking is applied to movement while the pointer is pressed Reviewed By: javache Differential Revision: D42977052 fbshipit-source-id: 2d48c35a908449d0b2338c33273fb75a430bc393
1 parent f7e35d4 commit bf3656b

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

ReactAndroid/src/main/java/com/facebook/react/uimanager/JSPointerDispatcher.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,6 @@ public void handleMotionEvent(
260260
break;
261261
case MotionEvent.ACTION_HOVER_MOVE:
262262
// TODO(luwe) - converge this with ACTION_MOVE
263-
264263
// If we don't move enough, ignore this event.
265264
float[] eventCoordinates = eventState.getEventCoordinatesByPointerId().get(activePointerId);
266265
float[] lastEventCoordinates =
@@ -275,18 +274,7 @@ public void handleMotionEvent(
275274
onMove(activeTargetTag, eventState, motionEvent, eventDispatcher);
276275
break;
277276
case MotionEvent.ACTION_MOVE:
278-
// TODO(luwe) - converge this with ACTION_HOVER_MOVE
279-
boolean listeningForMove =
280-
isAnyoneListeningForBubblingEvent(activeHitPath, EVENT.MOVE, EVENT.MOVE_CAPTURE);
281-
if (listeningForMove) {
282-
eventDispatcher.dispatchEvent(
283-
PointerEvent.obtain(
284-
PointerEventHelper.POINTER_MOVE,
285-
activeTargetTag,
286-
eventState,
287-
motionEvent,
288-
getCoalescingKey()));
289-
}
277+
onMove(activeTargetTag, eventState, motionEvent, eventDispatcher);
290278
break;
291279
case MotionEvent.ACTION_UP:
292280
case MotionEvent.ACTION_POINTER_UP:

0 commit comments

Comments
 (0)