Skip to content

Commit 9be2959

Browse files
dmytrorykunkelset
authored andcommitted
Use RN Build Utils for Building Hermes Artifacts
Summary: We moved Hermes some build utils from [Hermes repo](https://github.com/facebook/hermes/tree/main/utils) to [React Navtie repo](https://github.com/facebook/react-native/tree/main/sdks/hermes-engine/utils) a while ago to have more control over them. However some paths on the CI were not updated. We continued to use old build scripts for Hermes prebuilds. Some unfortunate side effects are: - `HERMES_ENABLE_DEBUGGER` is [hardcoded to true](https://github.com/facebook/hermes/blob/main/utils/build-apple-framework.sh#L65). That makes Hermes much slower in Release configuration. - BUILD_TYPE is [set to Release](https://github.com/facebook/hermes/blob/main/utils/build-apple-framework.sh#L10) instead of `MinSizeRel` which inreases Hermes binary size. This diff copies these build utils from RN to Hermes source directory before we perform Hermes build. Changelog [Internal] Reviewed By: cipolleschi Differential Revision: D44066721 fbshipit-source-id: f45ad6a31fb01c10199f69cc7bbcbbc83b793d34
1 parent 256e25c commit 9be2959

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1244,6 +1244,7 @@ jobs:
12441244
command: |
12451245
mkdir -p $HERMES_OSXBIN_ARTIFACTS_DIR ./sdks/hermes
12461246
cp -r $HERMES_WS_DIR/hermes/* ./sdks/hermes/.
1247+
cp -r ./sdks/hermes-engine/utils ./sdks/hermes/.
12471248
- brew_install:
12481249
package: cmake
12491250
- with_hermes_tarball_cache_span:

0 commit comments

Comments
 (0)