Skip to content

Commit 5dedf27

Browse files
cortinicofacebook-github-bot
authored andcommitted
Fix broken Loading/Refreshing indicator on Android
Summary: The Loading.../Refreshing... indicator is currently broken on Android. The reason is related to D42599220 We used to have a Toast shown to users on Android as a fallback, but as the DevLoadingView is not always loaded as a module in the core package, this ends up in the banner never beign shown to the user (on RN Tester or template apps). Changelog: [Android] [Fixed] - Fix broken Loading/Refreshing indicator on Android Reviewed By: cipolleschi Differential Revision: D49876757 fbshipit-source-id: 400e002327ebca908e3e7a7f81c5066888ac4e9b
1 parent 113de6e commit 5dedf27

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import com.facebook.react.modules.blob.FileReaderModule;
2727
import com.facebook.react.modules.camera.ImageStoreManager;
2828
import com.facebook.react.modules.clipboard.ClipboardModule;
29+
import com.facebook.react.modules.devloading.DevLoadingModule;
2930
import com.facebook.react.modules.devtoolssettings.DevToolsSettingsManagerModule;
3031
import com.facebook.react.modules.dialog.DialogModule;
3132
import com.facebook.react.modules.fresco.FrescoModule;
@@ -73,6 +74,7 @@
7374
AppearanceModule.class,
7475
AppStateModule.class,
7576
BlobModule.class,
77+
DevLoadingModule.class,
7678
FileReaderModule.class,
7779
ClipboardModule.class,
7880
DialogModule.class,
@@ -114,6 +116,8 @@ public MainReactPackage(MainPackageConfig config) {
114116
return new AppStateModule(context);
115117
case BlobModule.NAME:
116118
return new BlobModule(context);
119+
case DevLoadingModule.NAME:
120+
return new DevLoadingModule(context);
117121
case FileReaderModule.NAME:
118122
return new FileReaderModule(context);
119123
case ClipboardModule.NAME:
@@ -260,6 +264,7 @@ public ReactModuleInfoProvider getReactModuleInfoProvider() {
260264
AppearanceModule.class,
261265
AppStateModule.class,
262266
BlobModule.class,
267+
DevLoadingModule.class,
263268
FileReaderModule.class,
264269
ClipboardModule.class,
265270
DialogModule.class,

0 commit comments

Comments
 (0)