Skip to content

Commit 2b932c3

Browse files
NickGerlemanfacebook-github-bot
authored andcommitted
Change how we set cmake policy (#37349)
Summary: Pull Request resolved: #37349 X-link: facebook/yoga#1288 Fixes facebook/yoga#1283 New versions of CMake add "policies" which control how the build system acts wrt breaking changes. By default, CMake will emulate the behavior of the version specified in `cmake_minimum_required`. Setting a policy to true (to opt into new behavior where `cmake_minimum_required` is lower than the current version) seems actually just error out on the old versions. Googling around, apparently the way I should be doing this is to specify `<policy_max>` as part of `cmake_minimum_required `. https://gitlab.kitware.com/cmake/cmake/-/issues/20392 This should I think use new policies introduced up to 3.26 (what we test on right now), while letting 3.13 be the minimum. Reviewed By: cortinico Differential Revision: D45724864 fbshipit-source-id: 120cc2015a043605e7c07ef0459667643a4284b7
1 parent 11251c3 commit 2b932c3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/react-native/ReactCommon/yoga/yoga/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
# LICENSE file in the root directory of this source tree.
55

66

7-
cmake_minimum_required(VERSION 3.13)
7+
cmake_minimum_required(VERSION 3.13...3.26)
88
project(yogacore)
99
set(CMAKE_VERBOSE_MAKEFILE on)
1010

0 commit comments

Comments
 (0)