Skip to content

Commit 1904e80

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Remove support for Android API < 23 in ReactEditText (#39671)
Summary: Pull Request resolved: #39671 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactEditText changelog: [Android][Breaking] Remove support for Android API < 23 in ReactEditText Reviewed By: NickGerleman Differential Revision: D48545507 fbshipit-source-id: 98be52ba36248962864e99e80ff648bbb351ff61
1 parent c35dcb3 commit 1904e80

File tree

1 file changed

+4
-29
lines changed
  • packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput

1 file changed

+4
-29
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java

Lines changed: 4 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@
99

1010
import static com.facebook.react.uimanager.UIManagerHelper.getReactContext;
1111

12-
import android.content.ClipData;
13-
import android.content.ClipboardManager;
1412
import android.content.Context;
1513
import android.graphics.Color;
1614
import android.graphics.Paint;
@@ -210,9 +208,7 @@ public boolean onActionItemClicked(ActionMode mode, MenuItem item) {
210208
public void onDestroyActionMode(ActionMode mode) {}
211209
};
212210
setCustomSelectionActionModeCallback(customActionModeCallback);
213-
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
214-
setCustomInsertionActionModeCallback(customActionModeCallback);
215-
}
211+
setCustomInsertionActionModeCallback(customActionModeCallback);
216212
}
217213

218214
@Override
@@ -308,26 +304,7 @@ public InputConnection onCreateInputConnection(EditorInfo outAttrs) {
308304
@Override
309305
public boolean onTextContextMenuItem(int id) {
310306
if (id == android.R.id.paste) {
311-
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
312-
id = android.R.id.pasteAsPlainText;
313-
} else {
314-
ClipboardManager clipboard =
315-
(ClipboardManager) getContext().getSystemService(Context.CLIPBOARD_SERVICE);
316-
ClipData previousClipData = clipboard.getPrimaryClip();
317-
if (previousClipData != null) {
318-
for (int i = 0; i < previousClipData.getItemCount(); i++) {
319-
final CharSequence text = previousClipData.getItemAt(i).coerceToText(getContext());
320-
final CharSequence paste = (text instanceof Spanned) ? text.toString() : text;
321-
if (paste != null) {
322-
ClipData clipData = ClipData.newPlainText(null, text);
323-
clipboard.setPrimaryClip(clipData);
324-
}
325-
}
326-
boolean actionPerformed = super.onTextContextMenuItem(id);
327-
clipboard.setPrimaryClip(previousClipData);
328-
return actionPerformed;
329-
}
330-
}
307+
id = android.R.id.pasteAsPlainText;
331308
}
332309
return super.onTextContextMenuItem(id);
333310
}
@@ -702,10 +679,8 @@ public void maybeSetText(ReactTextUpdate reactTextUpdate) {
702679
}
703680
mDisableTextDiffing = false;
704681

705-
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
706-
if (getBreakStrategy() != reactTextUpdate.getTextBreakStrategy()) {
707-
setBreakStrategy(reactTextUpdate.getTextBreakStrategy());
708-
}
682+
if (getBreakStrategy() != reactTextUpdate.getTextBreakStrategy()) {
683+
setBreakStrategy(reactTextUpdate.getTextBreakStrategy());
709684
}
710685

711686
// Update cached spans (in Fabric only).

0 commit comments

Comments
 (0)