Skip to content

Commit 0c2f55d

Browse files
mganandrajkelset
authored andcommitted
Fixing failure building RN codegen CLI on Windows (#34791)
Summary: Ensuring the file paths uses forward slashes as separator to avoid the characters from being interpreted as ASCII escape characters. ## Changelog Fixing build failure building RN codegen CLI on Windows. Ensuring the file paths uses forward slashes as separator to avoid the characters from being interpreted as ASCII escape characters. [Android] [Fixed] - Fixing failure building RN codegen CLI on Windows Pull Request resolved: #34791 Test Plan: Ensured RN main branch builds on Windows with new architecture turned on. Reviewed By: cipolleschi Differential Revision: D39889468 Pulled By: cipolleschi fbshipit-source-id: 7d79eac9f433908cc86dd7ca2eec841739ef6365 # Conflicts: # ReactAndroid/cmake-utils/ReactNative-application.cmake
1 parent e2645a5 commit 0c2f55d

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

ReactAndroid/cmake-utils/ReactNative-application.cmake

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,19 @@ set(CMAKE_VERBOSE_MAKEFILE on)
1818

1919
include(${REACT_ANDROID_DIR}/cmake-utils/Android-prebuilt.cmake)
2020

21-
file(GLOB input_SRC CONFIGURE_DEPENDS
21+
set(BUILD_DIR ${PROJECT_BUILD_DIR})
22+
if(CMAKE_HOST_WIN32)
23+
string(REPLACE "\\" "/" BUILD_DIR ${BUILD_DIR})
24+
endif()
25+
26+
file(GLOB input_SRC CONFIGURE_DEPENDS
2227
*.cpp
23-
${PROJECT_BUILD_DIR}/generated/rncli/src/main/jni/*.cpp)
28+
${BUILD_DIR}/generated/rncli/src/main/jni/*.cpp)
2429

2530
add_library(${CMAKE_PROJECT_NAME} SHARED ${input_SRC})
2631

27-
target_include_directories(${CMAKE_PROJECT_NAME}
28-
PUBLIC
32+
target_include_directories(${CMAKE_PROJECT_NAME}
33+
PUBLIC
2934
${CMAKE_CURRENT_SOURCE_DIR}
3035
${PROJECT_BUILD_DIR}/generated/rncli/src/main/jni)
3136

0 commit comments

Comments
 (0)