Skip to content

Commit 60d9aa0

Browse files
committed
Construct our own source if not available
1 parent a3ae31e commit 60d9aa0

File tree

1 file changed

+15
-1
lines changed

1 file changed

+15
-1
lines changed

packages/react-dev-utils/failFast.js

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,23 @@
5050
const trace = document.createElement('div')
5151
applyStyles(trace, traceStyle)
5252
for (const frame of frames) {
53+
const { functionName, fileName, lineNumber } = frame
5354
const { source } = frame
5455
const elem = document.createElement('div')
55-
elem.appendChild(document.createTextNode(source))
56+
57+
// If source is available, use that (directly from browser) ...
58+
if (source != null) {
59+
elem.appendChild(document.createTextNode(`\t${source.trim()}`))
60+
} else {
61+
// We need to construct our own source since it wasn't given to us
62+
// This StackFrame is most likely from sourcemaps which means
63+
// column numbers aren't available ... so let's only show line numbers.
64+
if (functionName != null) {
65+
elem.appendChild(document.createTextNode(`\tat ${functionName} (${fileName}:${lineNumber})`))
66+
} else {
67+
elem.appendChild(document.createTextNode(`\tat ${fileName}:${lineNumber}`))
68+
}
69+
}
5670
trace.appendChild(elem)
5771
}
5872
overlay.appendChild(trace)

0 commit comments

Comments
 (0)