Skip to content

Commit 3c1211f

Browse files
committed
Warn about duplicate dependencies
1 parent a23cae5 commit 3c1211f

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

packages/react-scripts/config/webpack.config.dev.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ var HtmlWebpackPlugin = require('html-webpack-plugin');
1616
var CaseSensitivePathsPlugin = require('case-sensitive-paths-webpack-plugin');
1717
var InterpolateHtmlPlugin = require('react-dev-utils/InterpolateHtmlPlugin');
1818
var WatchMissingNodeModulesPlugin = require('react-dev-utils/WatchMissingNodeModulesPlugin');
19+
var DuplicatePackageCheckerPlugin = require('duplicate-package-checker-webpack-plugin');
1920
var getClientEnvironment = require('./env');
2021
var paths = require('./paths');
2122

@@ -228,6 +229,9 @@ module.exports = {
228229
// a plugin that prints an error when you attempt to do this.
229230
// See https://github.com/facebookincubator/create-react-app/issues/240
230231
new CaseSensitivePathsPlugin(),
232+
// Warn about duplicate dependencies.
233+
// See https://github.com/facebookincubator/create-react-app/issues/1844
234+
new DuplicatePackageCheckerPlugin(),
231235
// If you require a missing module and then `npm install` it, you still have
232236
// to restart the development server for Webpack to discover it. This plugin
233237
// makes the discovery automatic so you don't have to restart.

packages/react-scripts/config/webpack.config.prod.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ var HtmlWebpackPlugin = require('html-webpack-plugin');
1616
var ExtractTextPlugin = require('extract-text-webpack-plugin');
1717
var ManifestPlugin = require('webpack-manifest-plugin');
1818
var InterpolateHtmlPlugin = require('react-dev-utils/InterpolateHtmlPlugin');
19+
var DuplicatePackageCheckerPlugin = require('duplicate-package-checker-webpack-plugin');
1920
var paths = require('./paths');
2021
var getClientEnvironment = require('./env');
2122

@@ -263,6 +264,9 @@ module.exports = {
263264
screw_ie8: true
264265
}
265266
}),
267+
// Warn about duplicate dependencies.
268+
// See https://github.com/facebookincubator/create-react-app/issues/1844
269+
new DuplicatePackageCheckerPlugin(),
266270
// Note: this won't work without ExtractTextPlugin.extract(..) in `loaders`.
267271
new ExtractTextPlugin(cssFilename),
268272
// Generate a manifest file which contains a mapping of all asset filenames

packages/react-scripts/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
"css-loader": "0.26.1",
3838
"detect-port": "1.1.1",
3939
"dotenv": "2.0.0",
40+
"duplicate-package-checker-webpack-plugin": "^1.2.4",
4041
"eslint": "3.16.1",
4142
"eslint-config-react-app": "^0.6.2",
4243
"eslint-loader": "1.6.0",

0 commit comments

Comments
 (0)