fix: NO_PROXY should allow URIs with hyphens ("circleci-internal-outer-build-agent")

Signed-off-by: Marc Nuri <marc@marcnuri.com>

Author: manusa

CHANGELOG.md

@@ -3,6 +3,7 @@
 ### 6.2-SNAPSHOT
 
 #### Bugs
+fix #4373: NO_PROXY should allow URIs with hyphens ("circleci-internal-outer-build-agent")
 
 #### Improvements
 

kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/utils/HttpClientUtils.java

@@ -52,7 +52,7 @@ public class HttpClientUtils {
   private static final String BACKWARDS_COMPATIBILITY_DISABLE_DEFAULT = "true";
   private static final Pattern IPV4_PATTERN = Pattern.compile(
       "(http://|https://)?(?<ipAddressOrSubnet>(([01]?\\d\\d?|2[0-4]\\d|25[0-5])\\.){3}([01]?\\d\\d?|2[0-4]\\d|25[0-5])(\\/[0-9]\\d|1[0-9]\\d|2[0-9]\\d|3[0-2]\\d)?)");
-  private static final Pattern INVALID_HOST_PATTERN = Pattern.compile("[^\\da-zA-Z.-/:]+");
+  private static final Pattern INVALID_HOST_PATTERN = Pattern.compile("[^\\da-zA-Z.\\-/:]+");
   private static final AtomicBoolean MULTIPLE_HTTP_CLIENT_WARNING_LOGGED = new AtomicBoolean();
 
   private HttpClientUtils() {

kubernetes-client-api/src/test/java/io/fabric8/kubernetes/client/utils/HttpClientUtilsTest.java

@@ -109,7 +109,8 @@ Stream<Arguments> masterUrlMatchesNoProxyInput() {
           arguments("http://192.168.1.100:6443", new String[] { "192.168.1.0/24" }),
           arguments("master.example.com", new String[] { "master.example.com" }),
           arguments("master.example.com", new String[] { ".example.com" }),
-          arguments("master.example.com", new String[] { "one.com", "other.com", ".com" }),
+          arguments("master.example.com",
+              new String[] { "circleci-internal-outer-build-agent", "one.com", "other.com", ".com" }),
           arguments("192.168.1.110", new String[] { "192.168.1.110" }),
           arguments("192.168.1.110", new String[] { "http://192.168.1.110" }),
           arguments("192.168.1.110", new String[] { "https://192.168.1.110" }),
@@ -137,6 +138,7 @@ Stream<Arguments> masterUrlDoesNotMatchNoProxyInput() {
           arguments("master.example.com", new String[0]),
           arguments("master.example.com", new String[] { "master1.example.com" }),
           arguments("master.example.com", new String[] { ".example1.com" }),
+          arguments("master.example.com", new String[] { "circleci-internal-outer-build-agent", }),
           arguments("master.example.com", new String[] { "one.com", "other.com", "master.example.", ".co" }),
           arguments("192.168.1.110", new String[] { "192.168.1.111" }),
           arguments("192.168.1.110", new String[] { "http://192.168.1.111" }),