Skip to content

Commit 252e6f4

Browse files
committed
Call to implicitly deleted constructor
[build error](https://www.icloud.com/iclouddrive/083j4A7FWBweG3wFmAnHzDyfQ#call_to_implicitly_deleted_constructor) seems to be caused by the double declaration of primitive AccessibilityUnit:
1 parent 2fed660 commit 252e6f4

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

ReactCommon/react/renderer/attributedstring/TextAttributes.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ void TextAttributes::apply(TextAttributes textAttributes) {
9898
accessibilityRole = textAttributes.accessibilityRole.has_value()
9999
? textAttributes.accessibilityRole
100100
: accessibilityRole;
101-
accessibilityUnit = !textAttributes.accessibilityUnit.empty() ? textAttributes.accessibilityUnit
101+
accessibilityUnit = !textAttributes.accessibilityUnit.has_value() ? textAttributes.accessibilityUnit
102102
: accessibilityUnit;
103103
}
104104

ReactCommon/react/renderer/attributedstring/TextAttributes.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class TextAttributes : public DebugStringConvertible {
7979
// construction.
8080
std::optional<LayoutDirection> layoutDirection{};
8181
std::optional<AccessibilityRole> accessibilityRole{};
82-
std::string accessibilityUnit{};
82+
AccessibilityUnit accessibilityUnit{};
8383

8484
#pragma mark - Operations
8585

ReactCommon/react/renderer/attributedstring/primitives.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,10 @@ enum class AccessibilityRole {
135135
Toolbar,
136136
};
137137

138+
struct AccessibilityUnit {
139+
std::string hours{""};
140+
};
141+
138142
enum class TextTransform {
139143
None,
140144
Uppercase,

0 commit comments

Comments
 (0)