Pylint fixes

Author: bcb

examples/fastapi_server.py

@@ -1,7 +1,7 @@
 """FastAPI server"""
 from fastapi import FastAPI, Request, Response
-from jsonrpcserver import dispatch, method, Ok, Result
 import uvicorn  # type: ignore
+from jsonrpcserver import dispatch, method, Ok, Result
 
 app = FastAPI()
 

jsonrpcserver/async_methods.py

@@ -1,3 +1,4 @@
+"""Async methods"""
 from typing import Any, Awaitable, Callable, Dict, Optional, cast
 
 from returns.result import Result
@@ -6,11 +7,11 @@
 
 Method = Callable[..., Awaitable[Result[SuccessResult, ErrorResult]]]
 Methods = Dict[str, Method]
-global_methods: Methods = dict()
+global_methods: Methods = {}
 
 
 def method(
-    f: Optional[Method] = None, name: Optional[str] = None
+    func: Optional[Method] = None, name: Optional[str] = None
 ) -> Callable[..., Awaitable[Any]]:
     """A decorator to add a function into jsonrpcserver's internal global_methods dict.
     The global_methods dict will be used by default unless a methods argument is passed
@@ -23,9 +24,9 @@ def foo():
             ...
     """
 
-    def decorator(func: Method) -> Method:
+    def decorator(func_: Method) -> Method:
         nonlocal name
-        global_methods[name or func.__name__] = func
-        return func
+        global_methods[name or func_.__name__] = func_
+        return func_
 
-    return decorator(f) if callable(f) else cast(Method, decorator)
+    return decorator(func) if callable(func) else cast(Method, decorator)

tests/test_async_dispatcher.py

@@ -87,14 +87,14 @@ async def test_dispatch_to_response_pure_success() -> None:
 @patch("jsonrpcserver.async_dispatcher.dispatch_request", side_effect=ValueError("foo"))
 @pytest.mark.asyncio
 async def test_dispatch_to_response_pure_server_error(_: Mock) -> None:
-    async def foo() -> Result:
+    async def ping() -> Result:
         return Ok()
 
     assert await dispatch_to_response_pure(
         deserializer=default_deserializer,
         validator=default_validator,
         post_process=identity,
         context=NOCONTEXT,
-        methods={"foo": foo},
-        request='{"jsonrpc": "2.0", "method": "foo", "id": 1}',
-    ) == Failure(ErrorResponse(ERROR_SERVER_ERROR, "Server error", "foo", None))
+        methods={"ping": ping},
+        request='{"jsonrpc": "2.0", "method": "ping", "id": 1}',
+    ) == Failure(ErrorResponse(ERROR_SERVER_ERROR, "Server error", "ping", None))

tests/test_dispatcher.py

@@ -2,7 +2,7 @@
 
 TODO: Add tests for dispatch_requests (non-pure version)
 """
-from typing import Any, Callable, Dict
+from typing import Any
 from unittest.mock import Mock, patch, sentinel
 import json
 import pytest
@@ -167,14 +167,14 @@ def f() -> Result:
 
 
 def test_validate_result_positionals() -> None:
-    def f(x: int) -> Result:
+    def f(_: int) -> Result:
         return Ok()
 
     assert validate_args(Request("f", [1], NOID), NOCONTEXT, f) == Success(f)
 
 
 def test_validate_result_positionals_not_passed() -> None:
-    def f(x: str) -> Result:
+    def f(_: str) -> Result:
         return Ok()
 
     assert validate_args(Request("f", {"foo": "bar"}, NOID), NOCONTEXT, f) == Failure(
@@ -185,7 +185,7 @@ def f(x: str) -> Result:
 
 
 def test_validate_result_keywords() -> None:
-    def f(**kwargs: str) -> Result:
+    def f(**_: str) -> Result:
         return Ok()
 
     assert validate_args(Request("f", {"foo": "bar"}, NOID), NOCONTEXT, f) == Success(f)