Allow single ternary operator use (#260)

Author: jagdish-15

src/main/java/analyzer/exercises/leap/AvoidConditionalLogic.java renamed to src/main/java/analyzer/exercises/leap/AvoidIfStatements.java

@@ -3,12 +3,12 @@
 import analyzer.Comment;
 
 /**
- * @see <a href="https://github.com/exercism/website-copy/blob/main/analyzer-comments/java/leap/avoid_conditional_logic.md">Markdown Template</a>
+ * @see <a href="https://github.com/exercism/website-copy/blob/main/analyzer-comments/java/leap/avoid_if_statements.md">Markdown Template</a>
  */
-class AvoidConditionalLogic extends Comment {
+class AvoidIfStatements extends Comment {
     @Override
     public String getKey() {
-        return "java.leap.avoid_conditional_logic";
+        return "java.leap.avoid_if_statements";
     }
 
     @Override

src/main/java/analyzer/exercises/leap/AvoidMultipleTernary.java

@@ -0,0 +1,18 @@
+package analyzer.exercises.leap;
+
+import analyzer.Comment;
+
+/**
+ * @see <a href="https://github.com/exercism/website-copy/blob/main/analyzer-comments/java/leap/avoid_multiple_ternary.md">Markdown Template</a>
+ */
+class AvoidMultipleTernary extends Comment {
+    @Override
+    public String getKey() {
+        return "java.leap.avoid_multiple_ternary";
+    }
+
+    @Override
+    public Type getType() {
+        return Type.ACTIONABLE;
+    }
+}

src/main/java/analyzer/exercises/leap/LeapAnalyzer.java

@@ -70,13 +70,15 @@ public void visit(IntegerLiteralExpr node, OutputCollector output) {
 
     @Override
     public void visit(IfStmt node, OutputCollector output) {
-        output.addComment(new AvoidConditionalLogic());
+        output.addComment(new AvoidIfStatements());
         super.visit(node, output);
     }
 
     @Override
     public void visit(ConditionalExpr node, OutputCollector output) {
-        output.addComment(new AvoidConditionalLogic());
+        if (node.getThenExpr().isConditionalExpr() || node.getElseExpr().isConditionalExpr()) {
+            output.addComment(new AvoidMultipleTernary());
+        }
         super.visit(node, output);
     }
 

src/test/java/analyzer/AnalyzerIntegrationTest.java

@@ -68,10 +68,11 @@ void lasagna(String scenario) throws IOException {
     @ValueSource(strings = {
             "HardCodedTestCases",
             "OptimalSolution",
+            "OptimalTernary",
             "UsingGregorianCalendar",
             "UsingIfStatements",
             "UsingJavaTime",
-            "UsingTernary",
+            "UsingMultipleTernary",
             "UsingTooManyChecks",
     })
     void leap(String scenario) throws IOException {

src/test/resources/analyzer/AnalyzerIntegrationTest.leap.OptimalTernary.approved.txt

@@ -0,0 +1,3 @@
+{
+  "comments": []
+}

src/test/resources/analyzer/AnalyzerIntegrationTest.leap.UsingIfStatements.approved.txt

@@ -1,7 +1,7 @@
 {
   "comments": [
     {
-      "comment": "java.leap.avoid_conditional_logic",
+      "comment": "java.leap.avoid_if_statements",
       "params": {},
       "type": "actionable"
     },

src/test/resources/analyzer/AnalyzerIntegrationTest.leap.UsingTernary.approved.txt renamed to src/test/resources/analyzer/AnalyzerIntegrationTest.leap.UsingMultipleTernary.approved.txt

@@ -1,7 +1,7 @@
 {
   "comments": [
     {
-      "comment": "java.leap.avoid_conditional_logic",
+      "comment": "java.leap.avoid_multiple_ternary",
       "params": {},
       "type": "actionable"
     },

src/test/resources/scenarios/leap/OptimalTernary.java

@@ -0,0 +1,5 @@
+class Leap {
+    boolean isLeapYear(int year) {
+        return (year % 100 == 0) ? (year % 400 == 0) : (year % 4 == 0);
+    }
+}