Skip to content

Commit 9113a9d

Browse files
committed
Fixed an issue where session heartbeat wasn't submitting the user
1 parent 26dcc93 commit 9113a9d

9 files changed

+60
-39
lines changed

dist/exceptionless.d.ts

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,7 @@ export declare class EventBuilder {
225225
setType(type: string): EventBuilder;
226226
setSource(source: string): EventBuilder;
227227
setReferenceId(referenceId: string): EventBuilder;
228+
setEventReference(name: string, id: string): EventBuilder;
228229
setMessage(message: string): EventBuilder;
229230
setGeo(latitude: number, longitude: number): EventBuilder;
230231
setUserIdentity(userInfo: IUserInfo): EventBuilder;
@@ -284,12 +285,12 @@ export declare class ExceptionlessClient {
284285
submitLog(source: string, message: string, level: string, callback?: (context: EventPluginContext) => void): void;
285286
createNotFound(resource: string): EventBuilder;
286287
submitNotFound(resource: string, callback?: (context: EventPluginContext) => void): void;
287-
createSessionStart(userIdentity?: string, userDisplayName?: string): EventBuilder;
288-
submitSessionStart(userIdentity?: string, userDisplayName?: string, callback?: (context: EventPluginContext) => void): void;
289-
createSessionEnd(userIdentity?: string, userDisplayName?: string): EventBuilder;
290-
submitSessionEnd(userIdentity?: string, userDisplayName?: string, callback?: (context: EventPluginContext) => void): void;
291-
createSessionHeartbeat(userIdentity?: string, userDisplayName?: string): EventBuilder;
292-
submitSessionHeartbeat(userIdentity?: string, userDisplayName?: string, callback?: (context: EventPluginContext) => void): void;
288+
createSessionStart(): EventBuilder;
289+
submitSessionStart(callback?: (context: EventPluginContext) => void): void;
290+
createSessionEnd(): EventBuilder;
291+
submitSessionEnd(callback?: (context: EventPluginContext) => void): void;
292+
createSessionHeartbeat(): EventBuilder;
293+
submitSessionHeartbeat(callback?: (context: EventPluginContext) => void): void;
293294
createEvent(pluginContextData?: ContextData): EventBuilder;
294295
submitEvent(event: IEvent, pluginContextData?: ContextData, callback?: (context: EventPluginContext) => void): void;
295296
updateUserEmailAndDescription(referenceId: string, email: string, description: string, callback?: (response: SubmissionResponse) => void): void;

dist/exceptionless.js

Lines changed: 23 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.node.js

Lines changed: 23 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.node.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/EventBuilder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class EventBuilder {
5353
throw new Error('Invalid name');
5454
}
5555

56-
if (!id ||!this.isValidIdentifier(id)) {
56+
if (!id || !this.isValidIdentifier(id)) {
5757
throw new Error(`Id ${this._validIdentifierErrorMessage}`);
5858
}
5959

src/plugins/default/HeartbeatPlugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export class HeartbeatPlugin implements IEventPlugin {
2424
} else {
2525
let user: IUserInfo = context.event.data['@user'];
2626
if (user && user.identity) {
27-
let submitHeartbeatFn = () => context.client.submitSessionHeartbeat(user.identity, user.name);
27+
let submitHeartbeatFn = () => context.client.createSessionHeartbeat().setUserIdentity(user).submit();
2828

2929
if (!this._heartbeatIntervalId) {
3030
this._lastUser = user;

0 commit comments

Comments
 (0)