Skip to content

Commit 72752c1

Browse files
committed
Fixed several bugs found during testing.
1 parent 33c3baa commit 72752c1

14 files changed

+47
-17
lines changed

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,13 @@ var client = require('exceptionless.node').ExceptionlessClient.default;
229229
client.config.serverUrl = 'http://localhost:50000';
230230
```
231231

232+
### General Data Protection Regulation
233+
By default the Exceptionless Client will report all available metadata including potential PII data.
234+
You can fine tune the collection of information via Data Exclusions or turning off collection completely.
235+
236+
Please visit the [wiki](https://github.com/exceptionless/Exceptionless.JavaScript/wiki/Configuration#general-data-protection-regulation)
237+
for detailed information on how to configure the client to meet your requirements.
238+
232239
## Support
233240

234241
If you need help, please contact us via in-app support, [open an issue](https://github.com/exceptionless/Exceptionless.JavaScript/issues/new) or [join our chat on gitter](https://gitter.im/exceptionless/Discuss). We’re always here to help if you have any questions!

dist/exceptionless.js

Lines changed: 9 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.node.js

Lines changed: 7 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.node.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.universal.js

Lines changed: 9 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.universal.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.universal.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/exceptionless.universal.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/configuration/Configuration.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,7 @@ export class Configuration implements IConfigurationSettings {
345345
this._includeCookies = val;
346346
this._includePostData = val;
347347
this._includeQueryString = val;
348+
this.log.info(`includePrivateInformation: ${val}`);
348349
this.changed();
349350
}
350351

src/exceptionless.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ import { Utils } from './Utils';
7373
defaults.serverUrl = settings.serverUrl;
7474
}
7575

76-
if (settings.includePrivateInformation) {
77-
defaults.includePrivateInformation = settings.includePrivateInformation;
76+
if (typeof settings.includePrivateInformation === 'string') {
77+
defaults.includePrivateInformation = settings.includePrivateInformation === 'false' ? false : true;
7878
}
7979
}
8080

src/submission/DefaultSubmissionClient.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,11 @@ export class DefaultSubmissionClient implements ISubmissionClient {
7373
private createSubmissionCallback(config: Configuration, callback: (response: SubmissionResponse) => void) {
7474
return (status, message, data?, headers?) => {
7575
const settingsVersion: number = headers && parseInt(headers[this.configurationVersionHeader], 10);
76-
SettingsManager.checkVersion(settingsVersion, config);
76+
if (!isNaN(settingsVersion)) {
77+
SettingsManager.checkVersion(settingsVersion, config);
78+
} else {
79+
config.log.error('No config version header was returned.');
80+
}
7781

7882
callback(new SubmissionResponse(status, message));
7983
};

0 commit comments

Comments
 (0)