Bug fixes for the heartbeat plugin

Author: niemyjski

dist/exceptionless.d.ts

@@ -179,7 +179,6 @@ export declare class Configuration implements IConfigurationSettings {
     defaultTags: string[];
     defaultData: Object;
     enabled: boolean;
-    enableSessions: boolean;
     environmentInfoCollector: IEnvironmentInfoCollector;
     errorParser: IErrorParser;
     lastReferenceIdManager: ILastReferenceIdManager;

dist/exceptionless.js

@@ -13,6 +13,7 @@
   var client = exceptionless.ExceptionlessClient.default;
   client.config.serverUrl = 'http://localhost:50000';
   client.config.useDebugLogger();
+  client.config.setUserIdentity('12345678', 'Blake');
 
   // set some default data
   client.config.defaultData['SampleUser'] = {

dist/exceptionless.js.map

@@ -114,7 +114,7 @@ export class ExceptionlessClient {
   }
 
   public submitSessionHeartbeat(userIdentity?:string, userDisplayName?:string, callback?: (context: EventPluginContext) => void): void {
-    this.createSessionEnd(userIdentity, userDisplayName).submit(callback);
+    this.createSessionHeartbeat(userIdentity, userDisplayName).submit(callback);
   }
 
   public createEvent(pluginContextData?: ContextData): EventBuilder {

dist/exceptionless.min.js

@@ -56,8 +56,6 @@ export class Configuration implements IConfigurationSettings {
    */
   public enabled: boolean = true;
 
-  public enableSessions: boolean = true;
-
   public environmentInfoCollector: IEnvironmentInfoCollector;
   public errorParser: IErrorParser;
   public lastReferenceIdManager: ILastReferenceIdManager = new DefaultLastReferenceIdManager();

dist/exceptionless.min.js.map

@@ -12,7 +12,6 @@ const SIGINT: string = 'SIGINT';
 const SIGINT_CODE: number = 2;
 
 let defaults = Configuration.defaults;
-defaults.enableSessions = false;
 defaults.environmentInfoCollector = new NodeEnvironmentInfoCollector();
 defaults.errorParser = new NodeErrorParser();
 defaults.moduleCollector = new NodeModuleCollector();

dist/exceptionless.node.js

@@ -51,6 +51,7 @@ if (settings && (settings.apiKey || settings.serverUrl)) {
   defaults.serverUrl = settings.serverUrl;
 }
 
+defaults.enableSessions = true;
 defaults.errorParser = new DefaultErrorParser();
 defaults.moduleCollector = new DefaultModuleCollector();
 defaults.requestInfoCollector = new DefaultRequestInfoCollector();

dist/exceptionless.node.js.map

@@ -10,12 +10,12 @@ export class HeartbeatPlugin implements IEventPlugin {
   private _lastUser: IUserInfo;
 
   public run(context: EventPluginContext, next?: () => void): void {
-    function clearHeartbeatInterval() {
+    let clearHeartbeatInterval = () => {
       if (this._heartbeatIntervalId) {
         clearInterval(this._heartbeatIntervalId);
         this._heartbeatIntervalId = 0;
       }
-    }
+    };
 
     let type = context.event.type;
     if (type !== 'heartbeat') {
@@ -25,16 +25,14 @@ export class HeartbeatPlugin implements IEventPlugin {
         let user: IUserInfo = context.event.data['@user'];
         if (user && user.identity) {
           let submitHeartbeatFn = () => context.client.submitSessionHeartbeat(user.identity, user.name);
+
           if (!this._heartbeatIntervalId) {
             this._lastUser = user;
-            this._heartbeatIntervalId = setInterval(submitHeartbeatFn, 30000);
           } else {
             clearHeartbeatInterval();
-
-            if (this._lastUser.identity !== user.identity) {
-              this._heartbeatIntervalId = setInterval(submitHeartbeatFn, 30000);
-            }
           }
+
+          this._heartbeatIntervalId = setInterval(submitHeartbeatFn, 30000);
         }
       }
     }