Fixed a bug where the circular reference json stringify helper was eating duplicate array values.

@ejsmith, would be nice to not include this but others are doing even
simpler validation...

Author: niemyjski

dist/exceptionless.js

@@ -2,11 +2,47 @@ import { Utils } from 'Utils';
 
 describe('Utils', () => {
   it('should stringify circular reference', () => {
-    var afoo:any = { a: 'foo' };
+    var afoo:any = {a: 'foo'};
     afoo.b = afoo;
 
     expect(Utils.stringify(afoo)).toBe('{"a":"foo"}');
-    expect(Utils.stringify({ one: afoo, two: afoo })).toBe('{"one":{"a":"foo"}}');
+    expect(Utils.stringify([{one: afoo, two: afoo}])).toBe('[{"one":{"a":"foo"}}]');
+  });
+
+  it('should stringify array', () => {
+    var error = {
+      "type": "error",
+      "data": {
+        "@error": {
+          "type": "Error",
+          "message": "string error message",
+          "stack_trace": [
+            {
+              "name": "throwStringErrorImpl",
+              "parameters": [],
+              "file_name": "http://localhost/index.js",
+              "line_number": 22,
+              "column": 9
+            },
+            {
+              "name": "throwStringError",
+              "parameters": [],
+              "file_name": "http://localhost/index.js",
+              "line_number": 10,
+              "column": 10
+            }, {
+              "name": "HTMLButtonElement.onclick",
+              "parameters": [],
+              "file_name": "http://localhost/",
+              "line_number": 22,
+              "column": 10
+            }]
+        }, "@submission_method": "onerror"
+      }, "tags": []
+    };
+
+    expect(Utils.stringify(error)).toBe(JSON.stringify(error));
+    expect(Utils.stringify([error, error])).toBe(JSON.stringify([error, error]));
   });
 
   it('should parse version from url', () => {

dist/exceptionless.js.map

@@ -92,19 +92,31 @@ export class Utils {
   }
 
   public static stringify(data:any): string {
-    var cache = [];
-
-    return JSON.stringify(data, function(key, value) {
-      if (typeof value === 'object' && value !== null) {
-        if (cache.indexOf(value) !== -1) {
-          // Circular reference found, discard key
-          return;
+    function stringifyImpl(data:any): string {
+      var cache = [];
+      return JSON.stringify(data, function(key:string, value:any) {
+        if (typeof value === 'object' && !!value) {
+          if (cache.indexOf(value) !== -1) {
+            // Circular reference found, discard key
+            return;
+          }
+
+          cache.push(value);
         }
 
-        cache.push(value);
+        return value;
+      });
+    }
+
+    if (toString.call(data) === '[object Array]') {
+      var result = [];
+      for (var index = 0; index < data.length; index++) {
+        result[index] = JSON.parse(stringifyImpl(data[index]));
       }
 
-      return value;
-    });
+      return JSON.stringify(result);
+    }
+
+    return stringifyImpl(data);
   }
 }