Skip to content

Commit 71720ac

Browse files
committed
Refactor wiring
1 parent 5daa642 commit 71720ac

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

docs/main/changelog.rst

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ Development version
1919
- Make refactoring of wiring module and tests.
2020
See PR # `#406 <https://github.com/ets-labs/python-dependency-injector/issues/406>`_.
2121
Thanks to `@withshubh <https://github.com/withshubh>`_ for the contribution:
22-
- Refactor unnecessary ``else`` / ``elif`` in ``wiring`` module when ``if`` block has a
23-
return statement.
2422
- Remove unused imports in tests.
2523
- Use literal syntax to create data structure in tests.
2624
- Add integration with a static analysis tool `DeepSource <https://deepsource.io/>`_.

src/dependency_injector/wiring.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,20 +122,21 @@ def resolve_provider(
122122
) -> Optional[providers.Provider]:
123123
if isinstance(provider, providers.Delegate):
124124
return self._resolve_delegate(provider)
125-
if isinstance(provider, (
125+
elif isinstance(provider, (
126126
providers.ProvidedInstance,
127127
providers.AttributeGetter,
128128
providers.ItemGetter,
129129
providers.MethodCaller,
130130
)):
131131
return self._resolve_provided_instance(provider)
132-
if isinstance(provider, providers.ConfigurationOption):
132+
elif isinstance(provider, providers.ConfigurationOption):
133133
return self._resolve_config_option(provider)
134-
if isinstance(provider, providers.TypedConfigurationOption):
134+
elif isinstance(provider, providers.TypedConfigurationOption):
135135
return self._resolve_config_option(provider.option, as_=provider.provides)
136-
if isinstance(provider, str):
136+
elif isinstance(provider, str):
137137
return self._resolve_string_id(provider, modifier)
138-
return self._resolve_provider(provider)
138+
else:
139+
return self._resolve_provider(provider)
139140

140141
def _resolve_string_id(
141142
self,

0 commit comments

Comments
 (0)