Skip to content

Commit b14cb0f

Browse files
committed
Fixed message signing errors that clobbered critical Error properties (#3356).
1 parent 4c86dc9 commit b14cb0f

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

packages/providers/src.ts/json-rpc-provider.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -298,16 +298,14 @@ export class JsonRpcSigner extends Signer implements TypedDataSigner {
298298
async signMessage(message: Bytes | string): Promise<string> {
299299
const data = ((typeof(message) === "string") ? toUtf8Bytes(message): message);
300300
const address = await this.getAddress();
301-
302-
303301
try {
304302
return await this.provider.send("personal_sign", [ hexlify(data), address.toLowerCase() ]);
305303
} catch (error) {
306304
if (typeof(error.message) === "string" && error.message.match(/user denied/i)) {
307305
logger.throwError("user rejected signing", Logger.errors.ACTION_REJECTED, {
308306
action: "signMessage",
309307
from: address,
310-
message: data
308+
messageData: message
311309
});
312310
}
313311
throw error;
@@ -326,7 +324,7 @@ export class JsonRpcSigner extends Signer implements TypedDataSigner {
326324
logger.throwError("user rejected signing", Logger.errors.ACTION_REJECTED, {
327325
action: "_legacySignMessage",
328326
from: address,
329-
message: data
327+
messageData: message
330328
});
331329
}
332330
throw error;
@@ -351,7 +349,7 @@ export class JsonRpcSigner extends Signer implements TypedDataSigner {
351349
logger.throwError("user rejected signing", Logger.errors.ACTION_REJECTED, {
352350
action: "_signTypedData",
353351
from: address,
354-
message: { domain: populated.domain, types, value: populated.value }
352+
messageData: { domain: populated.domain, types, value: populated.value }
355353
});
356354
}
357355
throw error;

0 commit comments

Comments
 (0)