From 9c05729021ee66637f11a14dcdf114f8201916d5 Mon Sep 17 00:00:00 2001 From: Abdelatif Guettouche Date: Fri, 5 Aug 2022 14:57:53 +0100 Subject: [PATCH 1/3] push.yml: Add platform.txt to the cache key list as it affects Arduino IDE. Signed-off-by: Abdelatif Guettouche --- .github/workflows/push.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml index f2f75d7b1ac..73262be0129 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/push.yml @@ -42,6 +42,7 @@ jobs: ./tools/dist ~/arduino_ide key: ${{ runner.os }}-${{ hashFiles('package/package_esp32_index.template.json', + 'platform.txt', 'tools/get.py', '.github/scripts/install-arduino-ide.sh') }} - name: Build Sketches From 3e7bb39af685ca3d23d75ad64da34c93e2d059a8 Mon Sep 17 00:00:00 2001 From: Abdelatif Guettouche Date: Fri, 5 Aug 2022 14:58:19 +0100 Subject: [PATCH 2/3] sketch_utils.sh: Increase warning level for CI builds. Signed-off-by: Abdelatif Guettouche --- .github/scripts/sketch_utils.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/sketch_utils.sh b/.github/scripts/sketch_utils.sh index 3a856202e51..55a1d5d8c2b 100755 --- a/.github/scripts/sketch_utils.sh +++ b/.github/scripts/sketch_utils.sh @@ -136,7 +136,7 @@ function build_sketch(){ # build_sketch [ex currfqbn=`echo $fqbn | jq -r --argjson i $i '.[$i]'` sketchname=$(basename $sketchdir) echo "Building $sketchname with FQBN=$currfqbn" - $ide_path/arduino-builder -compile -logger=human -core-api-version=10810 \ + $ide_path/arduino-builder -prefs="compiler.warning_flags.all=-Wall -Werror=all -Wextra" -compile -logger=human -core-api-version=10810 \ -fqbn=\"$currfqbn\" \ -warnings="all" \ -tools "$ide_path/tools-builder" \ From d292bf1e9cc4bb8e9977b5d4ea2a6ad1639d81e2 Mon Sep 17 00:00:00 2001 From: Abdelatif Guettouche Date: Fri, 5 Aug 2022 15:22:14 +0100 Subject: [PATCH 3/3] platform.txt: Remove Werror. Signed-off-by: Abdelatif Guettouche --- platform.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platform.txt b/platform.txt index 3cb29298791..8404c4fa766 100644 --- a/platform.txt +++ b/platform.txt @@ -106,8 +106,8 @@ compiler.size.cmd={compiler.prefix}size compiler.warning_flags=-w compiler.warning_flags.none=-w compiler.warning_flags.default= -compiler.warning_flags.more=-Wall -Werror=all -compiler.warning_flags.all=-Wall -Werror=all -Wextra +compiler.warning_flags.more=-Wall +compiler.warning_flags.all=-Wall -Wextra # These can be overridden in platform.local.txt compiler.c.extra_flags=