Skip to content

Commit 9b16112

Browse files
committed
fix(rgbled): neopixelWrite() is now deprecated
1 parent 6dfb92d commit 9b16112

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

cores/esp32/esp32-hal-rgb-led.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,13 @@
1616

1717
#include "esp32-hal-rgb-led.h"
1818

19+
// Backward compatibility - Deprecated. It will be removed in future releases.
20+
void neopixelWrite(uint8_t pin, uint8_t red_val, uint8_t green_val, uint8_t blue_val) __attribute__((deprecated("Use rgbLedWrite().")))
21+
{
22+
log_w("neopixelWrite() is deprecated. Use rgbLedWrite().");
23+
rgbLedWrite(pin, red_val, green_val, blue_val);
24+
}
25+
1926
void rgbLedWrite(uint8_t pin, uint8_t red_val, uint8_t green_val, uint8_t blue_val) {
2027
rgbLedWriteOrdered(pin, RGB_BUILTIN_LED_COLOR_ORDER, red_val, green_val, blue_val);
2128
}

cores/esp32/esp32-hal-rgb-led.h

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,8 @@ void rgbLedWriteOrdered(uint8_t pin, rgb_led_color_order_t order, uint8_t red_va
2929
// Will use RGB_BUILTIN_LED_COLOR_ORDER
3030
void rgbLedWrite(uint8_t pin, uint8_t red_val, uint8_t green_val, uint8_t blue_val);
3131

32-
// Backward compatibility
33-
void neopixelWrite(uint8_t pin, uint8_t red_val, uint8_t green_val, uint8_t blue_val) __attribute__((deprecated("Use rgbLedWrite().")))
34-
{
35-
log_w("neopixelWrite() is deprecated. Use rgbLedWrite().");
36-
rgbLedWrite(pin, red_val, green_val, blue_val);
37-
}
32+
// Backward compatibility - Deprecated. It will be removed in future releases.
33+
void neopixelWrite(uint8_t p, uint8_t r, uint8_t g, uint8_t b) __attribute__((deprecated("Use rgbLedWrite().")));
3834

3935
#ifdef __cplusplus
4036
}

0 commit comments

Comments
 (0)