fix(zigbee): Add check when adding a OTA cluster

P-R-O-C-H-Y · P-R-O-C-H-Y · commit 282ccc5841cc · 2025-03-27T17:28:36.000+01:00
diff --git a/libraries/Zigbee/src/ZigbeeEP.cpp b/libraries/Zigbee/src/ZigbeeEP.cpp
@@ -492,7 +492,11 @@ bool ZigbeeEP::addOTAClient(
     log_e("Failed to add OTA server endpoint: 0x%x: %s", ret, esp_err_to_name(ret));
     return false;
   }
-  esp_zb_cluster_list_add_ota_cluster(_cluster_list, ota_cluster, ESP_ZB_ZCL_CLUSTER_CLIENT_ROLE);
+  ret = esp_zb_cluster_list_add_ota_cluster(_cluster_list, ota_cluster, ESP_ZB_ZCL_CLUSTER_CLIENT_ROLE);
+  if (ret != ESP_OK) {
+    log_e("Failed to add OTA cluster: 0x%x: %s", ret, esp_err_to_name(ret));
+    return false;
+  }
   return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -492,7 +492,11 @@ bool ZigbeeEP::addOTAClient(`
`492`	`492`	`log_e("Failed to add OTA server endpoint: 0x%x: %s", ret, esp_err_to_name(ret));`
`493`	`493`	`return false;`
`494`	`494`	`}`
`495`		`- esp_zb_cluster_list_add_ota_cluster(_cluster_list, ota_cluster, ESP_ZB_ZCL_CLUSTER_CLIENT_ROLE);`
	`495`	`+ ret = esp_zb_cluster_list_add_ota_cluster(_cluster_list, ota_cluster, ESP_ZB_ZCL_CLUSTER_CLIENT_ROLE);`
	`496`	`+ if (ret != ESP_OK) {`
	`497`	`+ log_e("Failed to add OTA cluster: 0x%x: %s", ret, esp_err_to_name(ret));`
	`498`	`+ return false;`
	`499`	`+ }`
`496`	`500`	`return true;`
`497`	`501`	`}`
`498`	`502`