Expired check ALWAYS executes yield policy BEFORE checking expiration - that's wasted time.

dok-net · dok-net · commit 543766f95135 · 2021-04-05T17:32:15.000+02:00
Expired keeps executing yield policy on already expired oneShot - that's counter intuitive and wasted time.
diff --git a/cores/esp8266/PolledTimeout.h b/cores/esp8266/PolledTimeout.h
@@ -157,10 +157,9 @@ class timeoutTemplate
   IRAM_ATTR // fast
   bool expired()
   {
-    YieldPolicyT::execute(); //in case of DoNothing: gets optimized away
-    if(PeriodicT)           //in case of false: gets optimized away
-      return expiredRetrigger();
-    return expiredOneShot();
+    bool hasExpired = PeriodicT ? expiredRetrigger() : expiredOneShot();
+    if (!hasExpired) YieldPolicyT::execute(); //in case of DoNothing: gets optimized away
+    return hasExpired;
   }
 
   IRAM_ATTR // fast

Original file line number	Diff line number	Diff line change
`@@ -157,10 +157,9 @@ class timeoutTemplate`
`157`	`157`	`IRAM_ATTR // fast`
`158`	`158`	`bool expired()`
`159`	`159`	`{`
`160`		`- YieldPolicyT::execute(); //in case of DoNothing: gets optimized away`
`161`		`- if(PeriodicT) //in case of false: gets optimized away`
`162`		`- return expiredRetrigger();`
`163`		`- return expiredOneShot();`
	`160`	`+ bool hasExpired = PeriodicT ? expiredRetrigger() : expiredOneShot();`
	`161`	`+ if (!hasExpired) YieldPolicyT::execute(); //in case of DoNothing: gets optimized away`
	`162`	`+ return hasExpired;`
`164`	`163`	`}`
`165`	`164`
`166`	`165`	`IRAM_ATTR // fast`