Skip to content

Commit 70e84ec

Browse files
committed
fix(panel): don't reset the LCD if the bus is RGB bus and the ESP_PANEL_LCD_FLAGS_AUTO_DEL_PANEL_IO is enabled
1 parent 5cc0648 commit 70e84ec

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
### Bugfixes:
1010

1111
* fix(panel): init expander host with correct macro (#65)
12+
* fix(panel): don't reset the LCD if the bus is RGB bus and the `ESP_PANEL_LCD_FLAGS_AUTO_DEL_PANEL_IO` is enabled
1213
* fix(examples): fix lvgl port rotation issue when enabling avoid tearing by @NecroMancer05
1314

1415
## v0.1.4 - 2024-06-17

src/ESP_Panel.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,8 +509,11 @@ bool ESP_Panel::begin(void)
509509
#endif
510510
ESP_PANEL_CHECK_FALSE_RET(_lcd_bus_ptr->begin(), false, "Begin LCD bus failed");
511511
ESP_PANEL_CHECK_FALSE_RET(_lcd_ptr->init(), false, "Initialize LCD failed");
512-
ESP_PANEL_CHECK_FALSE_RET(_lcd_ptr->reset(), false, "Reset LCD failed");
513512
// Operate LCD device according to the optional configurations
513+
#if (ESP_PANEL_LCD_BUS_TYPE != ESP_PANEL_BUS_TYPE_RGB) || !ESP_PANEL_LCD_FLAGS_AUTO_DEL_PANEL_IO
514+
// We can't reset the LCD if the bus is RGB bus and the `ESP_PANEL_LCD_FLAGS_AUTO_DEL_PANEL_IO` is enabled
515+
ESP_PANEL_CHECK_FALSE_RET(_lcd_ptr->reset(), false, "Reset LCD failed");
516+
#endif
514517
#ifdef ESP_PANEL_LCD_SWAP_XY
515518
ESP_PANEL_CHECK_FALSE_RET(_lcd_ptr->swapXY(ESP_PANEL_LCD_SWAP_XY), false, "Swap XY failed");
516519
#endif

0 commit comments

Comments
 (0)