Skip to content
This repository was archived by the owner on Feb 6, 2021. It is now read-only.

Commit d3a4f4a

Browse files
author
Robert Jackson
committed
Deprecate ember-cli-htmlbars-inline-precompiler.
ember-cli-htmlbars@4.0.3+ emits a helpful deprecation message when it detects that ember-cli-htmlbars-inline-precompile is present. This adds a deprecation notice to the README.md, and ensures that this packages `included` hook does nothing when using ember-cli-htmlbars@4.0.2 or higher.
1 parent a6f25ed commit d3a4f4a

File tree

3 files changed

+19
-2
lines changed

3 files changed

+19
-2
lines changed

README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,15 @@
55
[![Ember Observer Score](http://emberobserver.com/badges/ember-cli-htmlbars-inline-precompile.svg)](http://emberobserver.com/addons/ember-cli-htmlbars-inline-precompile)
66
[![Dependency Status](https://david-dm.org/ember-cli/ember-cli-htmlbars-inline-precompile.svg)](https://david-dm.org/ember-cli/ember-cli-htmlbars-inline-precompile)
77

8+
9+
## **Deprecated**
10+
11+
Usage of this project is deprecated, its functionality has been migrated into
12+
[ember-cli-htmlbars](https://github.com/ember-cli/ember-cli-htmlbars) directly.
13+
Please upgrade to `ember-cli-htmlbars@4.0.3` or higher.
14+
15+
## Usage
16+
817
Precompile template strings within the tests of an Ember project via tagged
918
template strings:
1019

index.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ const AstPlugins = require('./lib/ast-plugins');
55
const VersionChecker = require('ember-cli-version-checker');
66
const SilentError = require('silent-error');
77
const debugGenerator = require('heimdalljs-logger');
8+
const semver = require('semver');
89

910
const _logger = debugGenerator('ember-cli-htmlbars-inline-precompile');
1011

@@ -31,9 +32,15 @@ module.exports = {
3132
included() {
3233
this._super.included.apply(this, arguments);
3334

34-
let emberCLIHtmlBars = this.project.findAddonByName('ember-cli-htmlbars');
35+
let projectEmberCliHtmlbars = this.project.findAddonByName('ember-cli-htmlbars');
36+
if(projectEmberCliHtmlbars && projectEmberCliHtmlbars.inlinePrecompilerRegistered) {
37+
return;
38+
}
3539

36-
if(emberCLIHtmlBars && emberCLIHtmlBars.inlinePrecompilerRegistered) {
40+
let parentEmberCliHtmlbars = this.parent.addons.find(a => a.name === 'ember-cli-htmlbars');
41+
if (parentEmberCliHtmlbars && semver.gt(parentEmberCliHtmlbars.pkg.version, '4.0.2')) {
42+
// ember-cli-htmlbars will issue a deprecation message, but we need to
43+
// ensure that we don't attempt to add the babel plugin
3744
return;
3845
}
3946

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
"ember-cli-version-checker": "^3.1.3",
3131
"hash-for-dep": "^1.5.1",
3232
"heimdalljs-logger": "^0.1.9",
33+
"semver": "^6.3.0",
3334
"silent-error": "^1.1.0"
3435
},
3536
"devDependencies": {

0 commit comments

Comments
 (0)