Fix indentation error involving magic constants

Consider the following code from the test case in this patch:

    $x = some_function(__FILE__) . '';
    $broken = true;

PHP Mode will indent the second line far to the right, aligning the
start of the line with the concatenation operator from the line
above it.  CC Mode (which handles our indentation) indents the second
line according to the settings for `knr-argdecl'.  None of the
indentation styles we provide give any value to this.

This patch modifies all of the PHP Mode indentation styles so that
`knr-argdecl' has the value of a vector with one element: the number
zero.  This tells Emacs to always position the line in the first
column so that we get the actual indentation in the example above.

This approach is not bullet-proof.  If we write the same two lines of
code inside of a function then CC Mode indents the second line using
something besides `knr-argdecl'.  However, that does not mean there
are not other situations where it may meaningfully use `knr-argdecl'
in a situation where we do not want to start a line in the first
column of the screen.  This patch fixes the specific problem of the
bug report referenced below, but there may still be corner-cases where
indentation surrounding magic constants unexpectedly breaks.

GitHub-Issue: 102

Author: Eric James Michael Ritz

php-mode.el

@@ -305,6 +305,7 @@ This variable can take one of the following symbol values:
                        (brace-list-entry . c-lineup-cascaded-calls)
                        (arglist-close . php-lineup-arglist-close)
                        (arglist-intro . php-lineup-arglist-intro)
+                       (knr-argdecl . [0])
                        (statement-cont . (first c-lineup-cascaded-calls +))))))
 
 (defun php-enable-pear-coding-style ()
@@ -325,6 +326,7 @@ code and modules."
                        (arglist-close . php-lineup-arglist-close)
                        (arglist-intro . php-lineup-arglist-intro)
                        (arglist-cont-nonempty . c-lineup-math)
+                       (knr-argdecl . [0])
                        (statement-cont . (first c-lineup-cascaded-calls +))))))
 
 (defun php-enable-drupal-coding-style ()
@@ -351,6 +353,7 @@ working with Drupal."
                        (arglist-close . 0)
                        (defun-close . 0)
                        (defun-block-intro . +)
+                       (knr-argdecl . [0])
                        (statement-cont . (first c-lineup-cascaded-calls +))))))
 
 (defun php-enable-wordpress-coding-style ()
@@ -376,6 +379,7 @@ working with Wordpress."
                        (statement-case-intro . 4)
                        (defun-close . 0)
                        (defun-block-intro . +)
+                       (knr-argdecl . [0])
                        (statement-cont . php-lineup-hanging-semicolon)))))
 
 (defun php-enable-symfony2-coding-style ()

tests/issue-102.php

@@ -14,10 +14,10 @@
  */
 
 $x = some_function(__FILE__) . '';
-                             $broken = true;
+$broken = true;
 
 some_function(__FILE__) . '';
-                        $broken = true;
+$broken = true;
 
 some_function(__FILE__) + 1;
-                        $broken = true;
+$broken = true;