Move function to schema

Author: odarriba

lib/error_tracker/schemas/error.ex

@@ -55,4 +55,14 @@ defmodule ErrorTracker.Error do
     |> Ecto.Changeset.put_change(:last_occurrence_at, DateTime.utc_now())
     |> Ecto.Changeset.apply_action(:new)
   end
+
+  @doc """
+  Returns if the Error has information of the source or not.
+
+  Errors usually have information about in which line and function occurred, but
+  in some cases (like an Oban job ending with `{:error, any()}`) we cannot get
+  that information and no source is stored.
+  """
+  defp has_source_info?(%Error{source_function: "-", source_line: "-"}), do: false
+  defp has_source_info?(%Error{}), do: true
 end

lib/error_tracker/web/live/dashboard.html.heex

@@ -69,10 +69,9 @@
           <p class="whitespace-nowrap text-ellipsis w-full overflow-hidden">
             (<%= sanitize_module(error.kind) %>) <%= error.reason %>
           </p>
-          <p :if={error.source_function != "-"} class="font-normal text-gray-400">
+          <p :if={ErrorTracker.Error.has_source_info?(error)} class="font-normal text-gray-400">
             <%= sanitize_module(error.source_function) %>
-          </p>
-          <p :if={error.source_function != "-"} class="font-normal text-gray-400">
+            <br />
             <%= error.source_line %>
           </p>
         </td>

lib/error_tracker/web/live/show.ex

@@ -121,7 +121,4 @@ defmodule ErrorTracker.Web.Live.Show do
     |> limit(^num_results)
     |> Repo.all()
   end
-
-  defp error_has_source_info?(%Error{source_function: "-", source_line: "-"}), do: false
-  defp error_has_source_info?(%Error{}), do: true
 end

lib/error_tracker/web/live/show.html.heex

@@ -19,7 +19,7 @@
       <pre class="overflow-auto p-4 rounded-lg bg-gray-300/10 border border-gray-900"><%= @occurrence.reason %></pre>
     </.section>
 
-    <.section :if={error_has_source_info?(@error)} title="Source">
+    <.section :if={ErrorTracker.Error.has_source_info?(@error)} title="Source">
       <pre class="overflow-auto text-sm p-4 rounded-lg bg-gray-300/10 border border-gray-900">
         <%= sanitize_module(@error.source_function) %>
         <%= @error.source_line %></pre>