Skip to content

Commit 1e4e2e8

Browse files
committed
Revert "Skip mypy type checking for 8.5 branch temporarily"
This reverts commit 03e16d8.
1 parent 03e16d8 commit 1e4e2e8

File tree

1 file changed

+26
-26
lines changed

1 file changed

+26
-26
lines changed

utils/build-dists.py

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -102,14 +102,14 @@ def test_dist(dist):
102102

103103
# Only need to test 'async_types' for non-aliased package
104104
# since 'aliased_types' tests both async and sync.
105-
# if dist_name == "elasticsearch":
106-
# run(
107-
# venv_python,
108-
# "-m",
109-
# "mypy",
110-
# "--strict",
111-
# os.path.join(base_dir, "test_elasticsearch/test_types/async_types.py"),
112-
# )
105+
if dist_name == "elasticsearch":
106+
run(
107+
venv_python,
108+
"-m",
109+
"mypy",
110+
"--strict",
111+
os.path.join(base_dir, "test_elasticsearch/test_types/async_types.py"),
112+
)
113113

114114
# Ensure that the namespaces are correct for the dist
115115
for suffix in ("", "1", "2", "5", "6", "7", "8", "9", "10"):
@@ -123,24 +123,24 @@ def test_dist(dist):
123123

124124
# Check that sync types work for 'elasticsearch' and
125125
# that aliased types work for 'elasticsearchX'
126-
# if dist_name == "elasticsearch":
127-
# run(
128-
# venv_python,
129-
# "-m",
130-
# "mypy",
131-
# "--strict",
132-
# os.path.join(base_dir, "test_elasticsearch/test_types/sync_types.py"),
133-
# )
134-
# else:
135-
# run(
136-
# venv_python,
137-
# "-m",
138-
# "mypy",
139-
# "--strict",
140-
# os.path.join(
141-
# base_dir, "test_elasticsearch/test_types/aliased_types.py"
142-
# ),
143-
# )
126+
if dist_name == "elasticsearch":
127+
run(
128+
venv_python,
129+
"-m",
130+
"mypy",
131+
"--strict",
132+
os.path.join(base_dir, "test_elasticsearch/test_types/sync_types.py"),
133+
)
134+
else:
135+
run(
136+
venv_python,
137+
"-m",
138+
"mypy",
139+
"--strict",
140+
os.path.join(
141+
base_dir, "test_elasticsearch/test_types/aliased_types.py"
142+
),
143+
)
144144

145145
# Uninstall the dist, see that we can't import things anymore
146146
run(venv_python, "-m", "pip", "uninstall", "--yes", dist_name)

0 commit comments

Comments
 (0)