Skip to content

Set no BOM in editorconfig #5659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2021
Merged

Set no BOM in editorconfig #5659

merged 1 commit into from
May 4, 2021

Conversation

stevejgordon
Copy link
Contributor

@stevejgordon stevejgordon commented May 1, 2021 •
edited
Loading

The .editorconfig change is applied by ReSharper code cleanup and avoid BOM changes affecting the check license headers action.

Mpdreamz
Mpdreamz reviewed May 3, 2021
View reviewed changes
.editorconfig
@@ -5,6 +5,7 @@ trim_trailing_whitespace=true
insert_final_newline=true

[*]
charset = utf-8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ grave omission !

Mpdreamz
Mpdreamz approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM, I don't think we need to change our header to the long form. We have explicit permission to use the short format given that's what most .NET repositories use (e.g the dotnet and microsoft repositories).

@stevejgordon stevejgordon force-pushed the misc/charset-and-resharper-header branch from 288e42e to e298cb1 Compare May 4, 2021 14:25
@stevejgordon stevejgordon force-pushed the misc/charset-and-resharper-header branch from e298cb1 to ac32d90 Compare May 4, 2021 14:28
@stevejgordon stevejgordon changed the title Set no BOM in editorconfig and update resharper config Set no BOM in editorconfig May 4, 2021
@stevejgordon stevejgordon merged commit e88c723 into 7.x May 4, 2021
@stevejgordon stevejgordon deleted the misc/charset-and-resharper-header branch May 4, 2021 14:53
github-actions bot pushed a commit that referenced this pull request May 4, 2021
@stevejgordon @github-actions
Add charset to editorconfig (#5659)
8377d6c
@github-actions github-actions bot mentioned this pull request May 4, 2021
Merged
github-actions bot pushed a commit that referenced this pull request May 4, 2021
@stevejgordon @github-actions
Add charset to editorconfig (#5659)
8b09aff
@github-actions github-actions bot mentioned this pull request May 4, 2021
Merged
stevejgordon added a commit that referenced this pull request May 4, 2021
@github-actions @stevejgordon
Add charset to editorconfig (#5659) (#5675)
7e31502 
Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
stevejgordon added a commit that referenced this pull request May 4, 2021
@github-actions @stevejgordon
Add charset to editorconfig (#5659) (#5676)
281a17b 
Co-authored-by: Steve Gordon <sgordon@hotmail.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevejgordon @Mpdreamz