Skip to content

Commit 8b79505

Browse files
committed
fix #275 better exception message when using a custom contract resolver that does not extend ElasticResolver
1 parent c84ad58 commit 8b79505

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

src/Nest.Tests.Unit/Nest.Tests.Unit.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,7 @@
215215
<Compile Include="Search\SearchType\ScriptFieldTests.cs" />
216216
<Compile Include="Internals\Serialize\SerializeTests.cs" />
217217
<Compile Include="Search\Sort\SortTests.cs" />
218+
<Compile Include="Settings\UsePrettyResponseTests.cs" />
218219
<Compile Include="Test.Designer.cs">
219220
<DependentUpon>Test.settings</DependentUpon>
220221
<AutoGen>True</AutoGen>

src/Nest/Resolvers/Converters/IndexNameMarkerConverter.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,14 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
2222
writer.WriteNull();
2323
return;
2424
}
25+
2526
var settings = serializer.ContractResolver as ElasticResolver;
2627
if (settings != null && settings.ConnectionSettings != null)
2728
{
2829
var typeName = marker.Resolve(settings.ConnectionSettings);
2930
writer.WriteValue(typeName);
3031
}
31-
else throw new Exception("Could not find connection settings on the json contract resolver");
32+
else throw new Exception("If you use a custom contract resolver be sure to subclass from ElasticResolver");
3233
}
3334

3435
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)

src/Nest/Resolvers/Converters/TypeNameMarkerConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public override void WriteJson(JsonWriter writer, object value, JsonSerializer s
2828
var typeName = marker.Resolve(settings.ConnectionSettings);
2929
writer.WriteValue(typeName);
3030
}
31-
else throw new Exception("Could not find connection settings on the json contract resolver");
31+
else throw new Exception("If you use a custom contract resolver be sure to subclass from ElasticResolver");
3232
}
3333

3434
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer)

0 commit comments

Comments
 (0)