Refine BooleanEndpoint so that 4xx status codes other than 404 are considered as errors (#853) (#856)

swallez · web-flow · commit f62cc7caf4dd · 2024-08-06T12:03:13.000+02:00
diff --git a/java-client/src/main/java/co/elastic/clients/transport/endpoints/BooleanEndpoint.java b/java-client/src/main/java/co/elastic/clients/transport/endpoints/BooleanEndpoint.java
@@ -39,7 +39,8 @@ public BooleanEndpoint(
 
     @Override
     public boolean isError(int statusCode) {
-        return statusCode >= 500;
+        // 404 indicates a 'false' result.
+        return statusCode != 404 && super.isError(statusCode);
     }
 
     public boolean getResult(int statusCode) {

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,8 @@ public BooleanEndpoint(`
`39`	`39`
`40`	`40`	`@Override`
`41`	`41`	`public boolean isError(int statusCode) {`
`42`		`- return statusCode >= 500;`
	`42`	`+ // 404 indicates a 'false' result.`
	`43`	`+ return statusCode != 404 && super.isError(statusCode);`
`43`	`44`	`}`
`44`	`45`
`45`	`46`	`public boolean getResult(int statusCode) {`