Skip to content

Commit 96d080d

Browse files
committed
unit test fixes
1 parent 3b2c997 commit 96d080d

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

java-client/src/test/java/co/elastic/clients/elasticsearch/_helpers/esql/EsqlAdapterEndToEndTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,11 @@ public void objectsTest() throws Exception {
134134
{
135135
EmpData emp = it.next();
136136
assertEquals("10042", emp.empNo);
137-
assertEquals(Arrays.asList("Architect", "Business Analyst", "Internship", "Junior Developer"), emp.jobPositions);
137+
assertEquals(4, emp.jobPositions.size());
138+
assertTrue(emp.jobPositions.contains("Architect"));
139+
assertTrue(emp.jobPositions.contains("Business Analyst"));
140+
assertTrue(emp.jobPositions.contains("Internship"));
141+
assertTrue(emp.jobPositions.contains("Junior Developer"));
138142

139143
assertEquals("1993-03-21T00:00:00Z[UTC]",
140144
DateTimeFormatter.ISO_DATE_TIME.format(emp.hireDate.toInstant().atZone(ZoneId.of("UTC")))
@@ -172,7 +176,11 @@ public void asyncObjects() throws Exception {
172176
{
173177
EmpData emp = it.next();
174178
assertEquals("10042", emp.empNo);
175-
assertEquals(Arrays.asList("Architect", "Business Analyst", "Internship", "Junior Developer"), emp.jobPositions);
179+
assertEquals(4, emp.jobPositions.size());
180+
assertTrue(emp.jobPositions.contains("Architect"));
181+
assertTrue(emp.jobPositions.contains("Business Analyst"));
182+
assertTrue(emp.jobPositions.contains("Internship"));
183+
assertTrue(emp.jobPositions.contains("Junior Developer"));
176184

177185
assertEquals("1993-03-21T00:00:00Z[UTC]",
178186
DateTimeFormatter.ISO_DATE_TIME.format(emp.hireDate.toInstant().atZone(ZoneId.of("UTC")))

java-client/src/test/java/co/elastic/clients/elasticsearch/spec_issues/SpecIssuesTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,12 +115,12 @@ public void i0297_mappingSettings() {
115115
.index("i0297")
116116
.settings(s -> s
117117
// This is "mapping" and not "mappings"
118-
.mapping(m -> m.totalFields(totalFields -> totalFields.limit(1001L)))
118+
.mapping(m -> m.totalFields(totalFields -> totalFields.limit("1001")))
119119
.otherSettings("foo", JsonData.of("bar"))
120120
)
121121
);
122122

123-
assertEquals("{\"settings\":{\"foo\":\"bar\",\"mapping\":{\"total_fields\":{\"limit\":1001}}}}", toJson(request));
123+
assertEquals("{\"settings\":{\"foo\":\"bar\",\"mapping\":{\"total_fields\":{\"limit\":\"1001\"}}}}", toJson(request));
124124
}
125125

126126
@Test

0 commit comments

Comments
 (0)