Refine BooleanEndpoint so that 4xx status codes other than 404 are considered as errors (#853) (#854)

github-actions[bot] · swallez · web-flow · commit 6d3ab19b464b · 2024-08-06T11:56:37.000+02:00
Co-authored-by: Sylvain Wallez &lt;sylvain@elastic.co&gt;
diff --git a/java-client/src/main/java/co/elastic/clients/transport/endpoints/BooleanEndpoint.java b/java-client/src/main/java/co/elastic/clients/transport/endpoints/BooleanEndpoint.java
@@ -41,7 +41,8 @@ public BooleanEndpoint(
 
     @Override
     public boolean isError(int statusCode) {
-        return statusCode >= 500;
+        // 404 indicates a 'false' result.
+        return statusCode != 404 && super.isError(statusCode);
     }
 
     public boolean getResult(int statusCode) {

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,8 @@ public BooleanEndpoint(`
`41`	`41`
`42`	`42`	`@Override`
`43`	`43`	`public boolean isError(int statusCode) {`
`44`		`- return statusCode >= 500;`
	`44`	`+ // 404 indicates a 'false' result.`
	`45`	`+ return statusCode != 404 && super.isError(statusCode);`
`45`	`46`	`}`
`46`	`47`
`47`	`48`	`public boolean getResult(int statusCode) {`