Skip to content

Commit 479d191

Browse files
Fix boolean json write in JacksonJsonpGenerator.
1 parent 941b0fd commit 479d191

File tree

2 files changed

+42
-1
lines changed

2 files changed

+42
-1
lines changed

java-client/src/main/java/co/elastic/clients/json/jackson/JacksonJsonpGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ public JsonGenerator write(String name, double value) {
182182
public JsonGenerator write(String name, boolean value) {
183183
try {
184184
generator.writeFieldName(name);
185-
generator.writeBooleanField(name, value);
185+
generator.writeBoolean(value);
186186
} catch (IOException e) {
187187
throw JacksonUtils.convertException(e);
188188
}
Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
package co.elastic.clients.json.jackson;
2+
3+
import jakarta.json.stream.JsonGenerator;
4+
import org.junit.Assert;
5+
import org.junit.Before;
6+
import org.junit.Test;
7+
8+
import java.io.StringWriter;
9+
10+
public class JacksonJsonpGeneratorTest extends Assert {
11+
JacksonJsonpGenerator jacksonJsonpGenerator;
12+
StringWriter sw;
13+
14+
@Before
15+
public void setup(){
16+
sw = new StringWriter();
17+
jacksonJsonpGenerator= (JacksonJsonpGenerator) new JacksonJsonProvider().createGenerator(sw);
18+
}
19+
20+
@Test
21+
public void testWriteBooleanTrue(){
22+
jacksonJsonpGenerator.writeStartObject();
23+
jacksonJsonpGenerator.write("test", true);
24+
jacksonJsonpGenerator.writeEnd();
25+
26+
jacksonJsonpGenerator.flush();
27+
28+
assertEquals("{\"test\":true}", sw.toString());
29+
}
30+
31+
@Test
32+
public void testWriteBooleanFalse(){
33+
jacksonJsonpGenerator.writeStartObject();
34+
jacksonJsonpGenerator.write("test", false);
35+
jacksonJsonpGenerator.writeEnd();
36+
37+
jacksonJsonpGenerator.flush();
38+
39+
assertEquals("{\"test\":false}", sw.toString());
40+
}
41+
}

0 commit comments

Comments
 (0)