Fixes CI

Author: sobolevn

classes/_registry.py

@@ -15,7 +15,11 @@ def choose_registry(  # noqa: WPS211
     instances: TypeRegistry,
     protocols: TypeRegistry,
 ) -> TypeRegistry:
-    """"""
+    """
+    Returns the appropriate registry to store the passed type.
+
+    It depends on how ``instance`` method is used and also on the type itself.
+    """
     if is_protocol:
         return protocols
 

classes/_typeclass.py

@@ -114,16 +114,12 @@
 
 See our `official docs <https://classes.readthedocs.io>`_ to learn more!
 """
-
-from abc import get_cache_token
 from functools import _find_impl  # type: ignore  # noqa: WPS450
-from types import MethodType
 from typing import (  # noqa: WPS235
     TYPE_CHECKING,
     Callable,
     Dict,
     Generic,
-    NoReturn,
     Optional,
     Type,
     TypeVar,

classes/contrib/mypy/validation/validate_instance_args.py

@@ -19,7 +19,7 @@
 
 @final
 class _ArgValidationContext(NamedTuple):
-    """"""
+    """Context for instance arg validation."""
 
     is_protocol: bool
     delegate: Optional[MypyType]
@@ -30,6 +30,14 @@ def check_type(
     passed_types: TupleType,
     ctx: MethodContext,
 ) -> _ArgValidationContext:
+    """
+    Checks that args to ``.instance`` method are correct.
+
+    We cannot use ``@overload`` on ``.instance`` because ``mypy``
+    does not correctly handle ``ctx.api.fail`` on ``@overload`` items:
+    it then tries new ones, which produce incorrect results.
+    So, that's why we need this custom checker.
+    """
     passed_args = passed_types.items
 
     is_protocol, protocol_check = _check_protocol_arg(passed_args[1], ctx)
@@ -72,10 +80,6 @@ def _check_delegate_arg(
     delegate: MypyType,
     ctx: MethodContext,
 ) -> Tuple[Optional[MypyType], bool]:
-    # TODO: maybe we need to inforce that `delegate` should be
-    # similar to `runtime_type`?
-    # For example, we can ask for subtypes of `runtime_type`.
-    # However, motivation is not clear for now.
     if isinstance(delegate, FunctionLike) and delegate.is_type_obj():
         return delegate.items()[-1].ret_type, True
     return None, True

classes/contrib/mypy/validation/validate_runtime.py

@@ -85,22 +85,18 @@ def check_instance_definition(
             ctx.context,
         )
 
-    return _RuntimeValidationContext(
-        runtime_type=runtime_type,
-        is_protocol=args_check.is_protocol,
-        check_result=all([
-            args_check.check_result,
-            instance_check,
-
-            _check_runtime_protocol(
-                runtime_type, ctx, is_protocol=args_check.is_protocol,
-            ),
-            _check_concrete_generics(
-                runtime_type, instance_type, args_check.delegate, ctx,
-            ),
-            _check_tuple_size(instance_type, ctx),
-        ],
-    ))
+    return _RuntimeValidationContext(runtime_type, args_check.is_protocol, all([
+        args_check.check_result,
+        instance_check,
+
+        _check_runtime_protocol(
+            runtime_type, ctx, is_protocol=args_check.is_protocol,
+        ),
+        _check_concrete_generics(
+            runtime_type, instance_type, args_check.delegate, ctx,
+        ),
+        _check_tuple_size(instance_type, ctx),
+    ]))
 
 
 def _check_runtime_protocol(

setup.cfg

@@ -35,11 +35,11 @@ ignore = D100, D104, D401, W504, X100, WPS121, RST299, RST303, RST304, DAR103, D
 
 per-file-ignores =
   classes/__init__.py: F401, WPS113, WPS436
-  classes/_typeclass.py: WPS320
+  classes/_typeclass.py: WPS320, WPS436
   # We need `assert`s to please mypy:
   classes/contrib/mypy/*.py: S101
   # There are multiple assert's in tests:
-  tests/*.py: S101, WPS226, WPS431, WPS432, WPS436
+  tests/*.py: S101, WPS202, WPS226, WPS431, WPS432, WPS436
 
 
 [isort]

tests/conftest.py

@@ -1,6 +1,7 @@
-import pytest
 from contextlib import contextmanager
 
+import pytest
+
 
 @pytest.fixture(scope='session')
 def clear_cache():

tests/test_suppots.py

@@ -1,4 +1,4 @@
-from typing import Sized, List
+from typing import List, Sized
 
 import pytest