fix(asDirectiveSpec): nullify the assigned controller when the element is removed

Author: drpicox

src/ng/directive/as.js

@@ -58,6 +58,11 @@ var componentAsDirective = ['$parse', function($parse) {
         // gets the controller of the current element (see jqLiteController for details)
         var controller = iElement.data('$' + controllerName + 'Controller');
         setter(scope, controller);
+
+        // when the element is removed, remove it from the scope assignment (nullify it)
+        iElement.on('$destroy', function() {
+          setter(scope, null);
+        });
       };
     }
   };

test/ng/directive/asSpec.js

@@ -54,6 +54,16 @@ describe('as', function() {
       expect($rootScope.$ctrl.myComponent2).toBe(myComponentController);
     });
 
+    it('should nullify the variable once the component is destroyed', function() {
+      $rootScope.$ctrl = {};
+      $compile('<div ng-if="!nullified"><my-component as="$ctrl.myComponent"></my-component></div>')($rootScope);
+      $rootScope.$apply('nullified = false');
+      expect($rootScope.$ctrl.myComponent).toBe(myComponentController);
+
+      $rootScope.$apply('nullified = true');
+      expect($rootScope.$ctrl.myComponent).toBe(null);
+    });
+
   });
 
   it('should be compatible with directives on entities with controller', function() {