Skip to content

Commit 29638e8

Browse files
authored
Delete obsolete comments (#115680)
Delete comments that refer to the old Windows-specific profiler attach implementation that was deleted by dotnet/coreclr#24670
1 parent ab105b5 commit 29638e8

File tree

3 files changed

+1
-17
lines changed

3 files changed

+1
-17
lines changed

src/coreclr/vm/finalizerthread.cpp

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -125,13 +125,8 @@ void FinalizerThread::FinalizeAllObjects()
125125

126126
void FinalizerThread::WaitForFinalizerEvent (CLREvent *event)
127127
{
128-
// Non-host environment
129-
130128
// We don't want kLowMemoryNotification to starve out kFinalizer
131-
// (as the latter may help correct the former), and we don't want either
132-
// to starve out kProfilingAPIAttach, as we want decent responsiveness
133-
// to a user trying to attach a profiler. So check in this order:
134-
// kProfilingAPIAttach alone (0 wait)
129+
// (as the latter may help correct the former). So check in this order:
135130
// kFinalizer alone (2s wait)
136131
// all events together (infinite wait)
137132

@@ -162,7 +157,6 @@ void FinalizerThread::WaitForFinalizerEvent (CLREvent *event)
162157
//
163158
// * kLowMemoryNotification (if it's non-NULL && g_fEEStarted)
164159
// * kFinalizer (always)
165-
// * kProfilingAPIAttach (if it's non-NULL)
166160
//
167161
// The enum code:MHandleType values become important here, as
168162
// WaitForMultipleObjects needs to wait on a contiguous set of non-NULL

src/coreclr/vm/profdetach.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@ void ProfilerDetachInfo::Init()
5555
}
5656

5757

58-
// ----------------------------------------------------------------------------
59-
// Implementation of ProfilingAPIAttachDetach statics
60-
6158

6259
// ----------------------------------------------------------------------------
6360
// ProfilingAPIDetach::Initialize

src/coreclr/vm/profilinghelper.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -411,13 +411,6 @@ EXTERN_C void STDMETHODCALLTYPE ProfileTailcallNaked(UINT_PTR clientData);
411411
// Notes:
412412
// This function (or one of its callees) will log an error to the event log
413413
// if there is a failure
414-
//
415-
// Assumptions:
416-
// InitializeProfiling is called during startup, AFTER the host has initialized its
417-
// settings and the config variables have been read, but BEFORE the finalizer thread
418-
// has entered its first wait state. ASSERTs are placed in
419-
// code:ProfilingAPIAttachDetach::Initialize (which is called by this function, and
420-
// which depends on these assumptions) to verify.
421414

422415
// static
423416
HRESULT ProfilingAPIUtility::InitializeProfiling()

0 commit comments

Comments
 (0)