Fixed test failure

gfoidl · gfoidl · commit b06ca3a5a6df · 2021-05-18T22:43:20.000+02:00
diff --git a/src/Http/Http/src/Features/QueryFeature.cs b/src/Http/Http/src/Features/QueryFeature.cs
@@ -61,13 +61,9 @@ public IQueryCollection Query
         {
             get
             {
-                if (_features.Collection == null)
+                if (_features.Collection is null)
                 {
-                    if (_parsedValues == null)
-                    {
-                        _parsedValues = QueryCollection.Empty;
-                    }
-                    return _parsedValues;
+                    return _parsedValues ?? QueryCollection.Empty;
                 }
 
                 var current = HttpRequestFeature.QueryString;
@@ -211,6 +207,11 @@ public void Append(ReadOnlySpan<char> key, ReadOnlySpan<char> value = default)
             /// </summary>
             public void Append(string key, string value)
             {
+                if (key.Length == 0)
+                {
+                    return;
+                }
+
                 if (_accumulator is null)
                 {
                     _accumulator = new AdaptiveCapacityDictionary<string, StringValues>(StringComparer.OrdinalIgnoreCase);

Original file line number	Diff line number	Diff line change
`@@ -61,13 +61,9 @@ public IQueryCollection Query`
`61`	`61`	`{`
`62`	`62`	`get`
`63`	`63`	`{`
`64`		`- if (_features.Collection == null)`
	`64`	`+ if (_features.Collection is null)`
`65`	`65`	`{`
`66`		`- if (_parsedValues == null)`
`67`		`- {`
`68`		`- _parsedValues = QueryCollection.Empty;`
`69`		`- }`
`70`		`- return _parsedValues;`
	`66`	`+ return _parsedValues ?? QueryCollection.Empty;`
`71`	`67`	`}`
`72`	`68`
`73`	`69`	`var current = HttpRequestFeature.QueryString;`
`@@ -211,6 +207,11 @@ public void Append(ReadOnlySpan<char> key, ReadOnlySpan<char> value = default)`
`211`	`207`	`/// </summary>`
`212`	`208`	`public void Append(string key, string value)`
`213`	`209`	`{`
	`210`	`+ if (key.Length == 0)`
	`211`	`+ {`
	`212`	`+ return;`
	`213`	`+ }`
	`214`	`+`
`214`	`215`	`if (_accumulator is null)`
`215`	`216`	`{`
`216`	`217`	`_accumulator = new AdaptiveCapacityDictionary<string, StringValues>(StringComparer.OrdinalIgnoreCase);`